Document the HttpClient uses KeepAlive, keeping sockets open for up to 60 seconds after a connectio…

Document the HttpClient uses KeepAlive, keeping sockets open for up to 60 seconds after a connection is complete.


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=9017

[Søren Gjesse, 2012-06-22 08:12:02]

lgtm

https://chromiumcodereview.appspot.com/10640017/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

https://chromiumcodereview.appspot.com/10640017/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:628: * use keep-alive. This means that sockets may be open
up to 60 seconds after
"it'll use keep-alive" -> it will try to reuse opened sockets for several
requests.

https://chromiumcodereview.appspot.com/10640017/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:628: * use keep-alive. This means that sockets may be open
up to 60 seconds after
"may be open up to 60 seconds after a requests have completed" -> "will be kept
open for some time after a requests have completed unless HTTP procedures
indicate that it must be closed as part of completing the request"

[Søren Gjesse, 2012-06-22 08:16:01]

http://codereview.chromium.org/10640017/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

http://codereview.chromium.org/10640017/diff/1/runtime/bin/http.dart#newcode628
runtime/bin/http.dart:628: * use keep-alive. This means that sockets may be open
up to 60 seconds after
On 2012/06/22 08:12:02, Søren Gjesse wrote:
> "it'll use keep-alive" -> it will try to reuse opened sockets for several
> requests.

Adding a bit more info.

"it'll use keep-alive" -> "it will try to reuse opened sockets for several
requests to support HTTP 1.1 persistent connections"

[Bill Hesse, 2012-06-22 08:33:44]

https://chromiumcodereview.appspot.com/10640017/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

https://chromiumcodereview.appspot.com/10640017/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:627: * with the [HttpClientConnection]s and when the
endpoint supports it, it'll
Isn't the real need for documentation on the HttpServer: "When the server
receives an HTTP client request with the keep-alive header, it will keep the
socket open until it has been idle for 60 seconds.  This may keep the server
program running.

[Søren Gjesse, 2012-06-22 08:50:24]

https://chromiumcodereview.appspot.com/10640017/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

https://chromiumcodereview.appspot.com/10640017/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:627: * with the [HttpClientConnection]s and when the
endpoint supports it, it'll
On 2012/06/22 08:33:44, Bill Hesse wrote:
> Isn't the real need for documentation on the HttpServer: "When the server
> receives an HTTP client request with the keep-alive header, it will keep the
> socket open until it has been idle for 60 seconds.  This may keep the server
> program running.

The HttpServer will keep running independently of persistent connections as it
has its listen socket open. HttpServer.close (maybe that should be renamed to
shutdown as well) will close all persistent connections and the listen socket.

[Anders Johnsen, 2012-06-22 09:13:23]

Ty, committing.

https://chromiumcodereview.appspot.com/10640017/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

https://chromiumcodereview.appspot.com/10640017/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:627: * with the [HttpClientConnection]s and when the
endpoint supports it, it'll
On 2012/06/22 08:50:24, Søren Gjesse wrote:
> On 2012/06/22 08:33:44, Bill Hesse wrote:
> > Isn't the real need for documentation on the HttpServer: "When the server
> > receives an HTTP client request with the keep-alive header, it will keep the
> > socket open until it has been idle for 60 seconds.  This may keep the server
> > program running.
> 
> The HttpServer will keep running independently of persistent connections as it
> has its listen socket open. HttpServer.close (maybe that should be renamed to
> shutdown as well) will close all persistent connections and the listen socket.

Done.

https://chromiumcodereview.appspot.com/10640017/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:628: * use keep-alive. This means that sockets may be open
up to 60 seconds after
On 2012/06/22 08:16:01, Søren Gjesse wrote:
> On 2012/06/22 08:12:02, Søren Gjesse wrote:
> > "it'll use keep-alive" -> it will try to reuse opened sockets for several
> > requests.
> 
> Adding a bit more info.
> 
> "it'll use keep-alive" -> "it will try to reuse opened sockets for several
> requests to support HTTP 1.1 persistent connections"

Done.

https://chromiumcodereview.appspot.com/10640017/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:628: * use keep-alive. This means that sockets may be open
up to 60 seconds after
On 2012/06/22 08:12:02, Søren Gjesse wrote:
> "it'll use keep-alive" -> it will try to reuse opened sockets for several
> requests.

Done.

https://chromiumcodereview.appspot.com/10640017/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:628: * use keep-alive. This means that sockets may be open
up to 60 seconds after
On 2012/06/22 08:12:02, Søren Gjesse wrote:
> "may be open up to 60 seconds after a requests have completed" -> "will be
kept
> open for some time after a requests have completed unless HTTP procedures
> indicate that it must be closed as part of completing the request"

Done.