Pepper Flash: Add trivial C++ wrappers for PPB_Flash_File_{ModuleLocal,FileRef}.

Pepper Flash: Add trivial C++ wrappers for PPB_Flash_File_{ModuleLocal,FileRef}.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144032

[yzshen1, 2012-06-22 16:55:25]

Please consider changing test_flash_file.{h,cc} to use the cpp wrapper.

http://codereview.chromium.org/10638007/diff/1/ppapi/cpp/private/flash_file.h
File ppapi/cpp/private/flash_file.h (right):

http://codereview.chromium.org/10638007/diff/1/ppapi/cpp/private/flash_file.h...
ppapi/cpp/private/flash_file.h:45: static bool GetDirContents(const
InstanceHandle& instance,
It seems good to have a comment that FreeDirContents is not needed.

http://codereview.chromium.org/10638007/diff/1/ppapi/cpp/private/flash_file.h...
ppapi/cpp/private/flash_file.h:60: static bool IsAvailable();
Add public, please.

[viettrungluu, 2012-06-23 00:10:01]

Test updated too. PTAL.

http://codereview.chromium.org/10638007/diff/1/ppapi/cpp/private/flash_file.h
File ppapi/cpp/private/flash_file.h (right):

http://codereview.chromium.org/10638007/diff/1/ppapi/cpp/private/flash_file.h...
ppapi/cpp/private/flash_file.h:45: static bool GetDirContents(const
InstanceHandle& instance,
On 2012/06/22 16:55:25, yzshen1 wrote:
> It seems good to have a comment that FreeDirContents is not needed.

Done.

http://codereview.chromium.org/10638007/diff/1/ppapi/cpp/private/flash_file.h...
ppapi/cpp/private/flash_file.h:60: static bool IsAvailable();
On 2012/06/22 16:55:25, yzshen1 wrote:
> Add public, please.

Done.

[yzshen1, 2012-06-23 00:17:41]

Please upload a new patch set.

On 2012/06/23 00:10:01, viettrungluu wrote:
> Test updated too. PTAL.
> 
> http://codereview.chromium.org/10638007/diff/1/ppapi/cpp/private/flash_file.h
> File ppapi/cpp/private/flash_file.h (right):
> 
>
http://codereview.chromium.org/10638007/diff/1/ppapi/cpp/private/flash_file.h...
> ppapi/cpp/private/flash_file.h:45: static bool GetDirContents(const
> InstanceHandle& instance,
> On 2012/06/22 16:55:25, yzshen1 wrote:
> > It seems good to have a comment that FreeDirContents is not needed.
> 
> Done.
> 
>
http://codereview.chromium.org/10638007/diff/1/ppapi/cpp/private/flash_file.h...
> ppapi/cpp/private/flash_file.h:60: static bool IsAvailable();
> On 2012/06/22 16:55:25, yzshen1 wrote:
> > Add public, please.
> 
> Done.

[viettrungluu, 2012-06-23 02:13:03]

D'oh. I knew I forgot something on my way out the door. Monday it'll have to be.

On 2012/06/23 00:17:41, yzshen1 wrote:
> Please upload a new patch set.
> 
> On 2012/06/23 00:10:01, viettrungluu wrote:
> > Test updated too. PTAL.
> > 
> >
http://codereview.chromium.org/10638007/diff/1/ppapi/cpp/private/flash_file.h
> > File ppapi/cpp/private/flash_file.h (right):
> > 
> >
>
http://codereview.chromium.org/10638007/diff/1/ppapi/cpp/private/flash_file.h...
> > ppapi/cpp/private/flash_file.h:45: static bool GetDirContents(const
> > InstanceHandle& instance,
> > On 2012/06/22 16:55:25, yzshen1 wrote:
> > > It seems good to have a comment that FreeDirContents is not needed.
> > 
> > Done.
> > 
> >
>
http://codereview.chromium.org/10638007/diff/1/ppapi/cpp/private/flash_file.h...
> > ppapi/cpp/private/flash_file.h:60: static bool IsAvailable();
> > On 2012/06/22 16:55:25, yzshen1 wrote:
> > > Add public, please.
> > 
> > Done.

[viettrungluu, 2012-06-25 16:39:16]

PTAL for realz this time.

[yzshen1, 2012-06-25 20:06:40]

lgtm

[commit-bot: I haz the power, 2012-06-25 21:20:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/10638007/9002

[commit-bot: I haz the power, 2012-06-25 22:19:32]

Change committed as 144032