Modify experimental identity flow to display scope descriptions and details.

chrome/common/net/gaia/oauth2_mint_token_flow.h

Index: chrome/common/net/gaia/oauth2_mint_token_flow.h
diff --git a/chrome/common/net/gaia/oauth2_mint_token_flow.h b/chrome/common/net/gaia/oauth2_mint_token_flow.h
index e50c526fce324b6a4f65f6fe383aa14938285e23..079d322c891040ce004002add3ced22c8753157a 100644
--- a/chrome/common/net/gaia/oauth2_mint_token_flow.h
+++ b/chrome/common/net/gaia/oauth2_mint_token_flow.h
@@ -8,6 +8,7 @@
 #include <string>
 #include <vector>
 
+#include "base/memory/ref_counted.h"
 #include "chrome/common/net/gaia/oauth2_api_call_flow.h"
 
 class GoogleServiceAuthError;
@@ -27,7 +28,7 @@ class URLRequestContextGetter;
 
 // IssueAdvice: messages to show to the user to get a user's approval.
 // The structure is as follows:
-// * Descritpion 1
+// * Description 1
 //   - Detail 1.1
 //   - Details 1.2
 // * Description 2
@@ -53,7 +54,8 @@ typedef std::vector<IssueAdviceInfoEntry> IssueAdviceInfo;
 // token for the given client and the given set of scopes from the
 // OAuthLogin scoped "master" OAuth2 token for the user logged in to
 // Chrome.
-class OAuth2MintTokenFlow : public OAuth2ApiCallFlow {
+class OAuth2MintTokenFlow : public OAuth2ApiCallFlow,
+                            public base::RefCounted<OAuth2MintTokenFlow> {

[Munjal (Google), 2012/06/25 20:40:09]

Is there anyway we can avoid making this a ref counted class (assuming it forces
consumers of this class to always use scoped_refptr)?

[Evan Stade, 2012/06/26 00:56:03]

changed to use weak ptrs.

  public:
   // There are four differnt modes when minting a token to grant
   // access to third-party app for a user.
@@ -137,7 +139,7 @@ class OAuth2MintTokenFlow : public OAuth2ApiCallFlow {
       ProcessMintAccessTokenFailure);
 
   void ReportSuccess(const std::string& access_token);
-  void ReportSuccess(const IssueAdviceInfo& issue_advice);
+  void ReportIssueAdviceSuccess(const IssueAdviceInfo& issue_advice);
   void ReportFailure(const GoogleServiceAuthError& error);
 
   static bool ParseIssueAdviceResponse(