Modify experimental identity flow to display scope descriptions and details.

chrome/common/net/gaia/oauth2_mint_token_flow.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_NET_GAIA_OAUTH2_MINT_TOKEN_FLOW_H_
 #define CHROME_COMMON_NET_GAIA_OAUTH2_MINT_TOKEN_FLOW_H_
 
 #include <string>
 #include <vector>
 
+#include "base/memory/ref_counted.h"
 #include "chrome/common/net/gaia/oauth2_api_call_flow.h"
 
 class GoogleServiceAuthError;
 class OAuth2MintTokenFlowTest;
 
 namespace base {
 class DictionaryValue;
 }
 
 namespace content {
 class URLFetcher;
 }
 
 namespace net {
 class URLRequestContextGetter;
 }
 
 // IssueAdvice: messages to show to the user to get a user's approval.
 // The structure is as follows:
-// * Descritpion 1
+// * Description 1
 //   - Detail 1.1
 //   - Details 1.2
 // * Description 2
 //   - Detail 2.1
 //   - Detail 2.2
 //   - Detail 2.3
 // * Description 3
 //   - Detail 3.1
 struct IssueAdviceInfoEntry {
  public:
   IssueAdviceInfoEntry();
   ~IssueAdviceInfoEntry();
 
   std::string description;
   std::vector<std::string> details;
 
   bool operator==(const IssueAdviceInfoEntry& rhs) const;
 };
 
 typedef std::vector<IssueAdviceInfoEntry> IssueAdviceInfo;
 
 // This class implements the OAuth2 flow to Google to mint an OAuth2
 // token for the given client and the given set of scopes from the
 // OAuthLogin scoped "master" OAuth2 token for the user logged in to
 // Chrome.
-class OAuth2MintTokenFlow : public OAuth2ApiCallFlow {
+class OAuth2MintTokenFlow : public OAuth2ApiCallFlow,
+                            public base::RefCounted<OAuth2MintTokenFlow> {

[Munjal (Google), 2012/06/25 20:40:09]

Is there anyway we can avoid making this a ref counted class (assuming it forces
consumers of this class to always use scoped_refptr)?

[Evan Stade, 2012/06/26 00:56:03]

changed to use weak ptrs.

  public:
   // There are four differnt modes when minting a token to grant
   // access to third-party app for a user.
   enum Mode {
     // Get the messages to display to the user without minting a token.
     MODE_ISSUE_ADVICE,
     // Record a grant but do not get a token back.
     MODE_RECORD_GRANT,
     // Mint a token for an existing grant.
     MODE_MINT_TOKEN_NO_FORCE,
@@ skipping 63 matching lines @@
   friend class OAuth2MintTokenFlowTest;
   FRIEND_TEST_ALL_PREFIXES(OAuth2MintTokenFlowTest, CreateApiCallBody);
   FRIEND_TEST_ALL_PREFIXES(OAuth2MintTokenFlowTest, ParseIssueAdviceResponse);
   FRIEND_TEST_ALL_PREFIXES(OAuth2MintTokenFlowTest, ParseMintTokenResponse);
   FRIEND_TEST_ALL_PREFIXES(OAuth2MintTokenFlowTest, ProcessApiCallSuccess);
   FRIEND_TEST_ALL_PREFIXES(OAuth2MintTokenFlowTest, ProcessApiCallFailure);
   FRIEND_TEST_ALL_PREFIXES(OAuth2MintTokenFlowTest,
       ProcessMintAccessTokenFailure);
 
   void ReportSuccess(const std::string& access_token);
-  void ReportSuccess(const IssueAdviceInfo& issue_advice);
+  void ReportIssueAdviceSuccess(const IssueAdviceInfo& issue_advice);
   void ReportFailure(const GoogleServiceAuthError& error);
 
   static bool ParseIssueAdviceResponse(
       const base::DictionaryValue* dict, IssueAdviceInfo* issue_advice);
   static bool ParseMintTokenResponse(
       const base::DictionaryValue* dict, std::string* access_token);
 
   net::URLRequestContextGetter* context_;
   Delegate* delegate_;
   Parameters parameters_;
 
   DISALLOW_COPY_AND_ASSIGN(OAuth2MintTokenFlow);
 };
 
 #endif  // CHROME_COMMON_NET_GAIA_OAUTH2_MINT_TOKEN_FLOW_H_