Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 10630013: Adds LocationBarContainer that contains (Closed)

Created:
8 years, 6 months ago by sky
Modified:
8 years, 6 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Adds LocationBarContainer that contains LocationBarView. LocationBarContainer is a child of BrowserView so that it can be placed outside of the ToolbarView. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143599

Patch Set 1 #

Patch Set 2 : Removed debugging code #

Total comments: 1

Patch Set 3 : Remove set_view_to_focus #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -18 lines) Patch
M chrome/browser/ui/views/frame/browser_view.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 7 chunks +13 lines, -2 lines 0 comments Download
A chrome/browser/ui/views/location_bar/location_bar_container.h View 1 chunk +83 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/location_bar/location_bar_container.cc View 1 chunk +78 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/location_bar/location_bar_container_aura.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/location_bar/location_bar_container_win.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 2 5 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 2 11 chunks +35 lines, -10 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/animation/bounds_animator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/animation/bounds_animator.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
8 years, 6 months ago (2012-06-21 20:35:06 UTC) #1
Ben Goodger (Google)
8 years, 6 months ago (2012-06-21 21:52:57 UTC) #2
lgtm

http://codereview.chromium.org/10630013/diff/2001/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/location_bar_container.h (right):

http://codereview.chromium.org/10630013/diff/2001/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/location_bar_container.h:55: //
views::BoundsAnimator overrides:
BoundsAnimatorObserver?

Powered by Google App Engine
This is Rietveld 408576698