Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/bookmarks/bookmark_storage.cc

Issue 10605003: Fixing some more instances where I put in HistoryServiceFactory::GetForProfile which will force cre… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/bookmarks/bookmark_model.cc ('K') | « chrome/browser/bookmarks/bookmark_model_unittest.cc ('k') | chrome/browser/download/download_history.cc » ('j') | chrome/browser/history/android/android_history_provider_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_storage.cc
===================================================================
--- chrome/browser/bookmarks/bookmark_storage.cc (revision 143165)
+++ chrome/browser/bookmarks/bookmark_storage.cc (working copy)
@@ -144,8 +144,8 @@
void BookmarkStorage::MigrateFromHistory() {
// We need to wait until history has finished loading before reading
// from generated bookmarks file.
- HistoryService* history =
sky 2012/06/21 17:14:31 Keep this as it was.
- HistoryServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);
+ HistoryService* history = HistoryServiceFactory::GetForProfileIfExists(
+ profile_, Profile::EXPLICIT_ACCESS);
if (!history) {
// This happens in unit tests.
if (model_)
« chrome/browser/bookmarks/bookmark_model.cc ('K') | « chrome/browser/bookmarks/bookmark_model_unittest.cc ('k') | chrome/browser/download/download_history.cc » ('j') | chrome/browser/history/android/android_history_provider_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698