chrome/browser/bookmarks/bookmark_model_unittest.cc - Issue 10605003: Fixing some more instances where I put in HistoryServiceFactory::GetForProfile which will force cre…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_model_unittest.cc

Issue 10605003: Fixing some more instances where I put in HistoryServiceFactory::GetForProfile which will force cre… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/bookmarks/bookmark_model.cc ('K') | « chrome/browser/bookmarks/bookmark_model.cc ('k') | chrome/browser/bookmarks/bookmark_storage.cc » ('j') | chrome/browser/bookmarks/bookmark_storage.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bookmarks/bookmark_model_unittest.cc

===================================================================

--- chrome/browser/bookmarks/bookmark_model_unittest.cc (revision 143165)

+++ chrome/browser/bookmarks/bookmark_model_unittest.cc (working copy)

@@ -1069,7 +1069,8 @@

// This won't actually delete the URL, rather it'll empty out the visits.

// This triggers blocking on the BookmarkModel.

- profile_->GetHistoryService(Profile::EXPLICIT_ACCESS)->DeleteURL(url);

+ HistoryServiceFactory::GetForProfile(

+ profile_, Profile::EXPLICIT_ACCESS)->DeleteURL(url);

}

TEST_F(BookmarkModelTest, Sort) {