Issue 10605002: Sandbox: Use ScopedProcessInformation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10605002: Sandbox: Use ScopedProcessInformation. (Closed)

Created:
8 years, 6 months ago by rvargas (doing something else)

Modified:
8 years, 5 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Sandbox: Use ScopedProcessInformation. This is a partial reland of 130716 - Use ScopedProcessInformation and other RAII types in sandbox - minus the bugs introduced by that cl. BUG=127931 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144571

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -186 lines)			Patch
M	sandbox/src/Wow64.cc	View	1	3 chunks	+7 lines, -8 lines	0 comments	Download
M	sandbox/src/broker_services.cc	View	1	10 chunks	+43 lines, -49 lines	0 comments	Download
M	sandbox/src/job_unittest.cc	View	1	3 chunks	+7 lines, -6 lines	0 comments	Download
M	sandbox/src/policy_target_test.cc	View	1	5 chunks	+20 lines, -23 lines	0 comments	Download
M	sandbox/src/process_policy_test.cc	View	1	7 chunks	+12 lines, -11 lines	0 comments	Download
M	sandbox/src/restricted_token_utils.cc	View	1	3 chunks	+13 lines, -12 lines	0 comments	Download
M	sandbox/src/target_process.h	View	1	5 chunks	+19 lines, -18 lines	0 comments	Download
M	sandbox/src/target_process.cc	View	1	10 chunks	+55 lines, -59 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

Please take a look. Patch set 1 is the code that was checked in before, ...

8 years, 6 months ago (2012-06-26 20:55:07 UTC) #1

lgtm

Expand Messages | Collapse Messages