Issue 106008: Fix Flash window in Analytics being incorrectly visible....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 106008: Fix Flash window in Analytics being incorrectly visible.... (Closed)

Created:
11 years, 7 months ago by jam

Modified:
9 years, 6 months ago

Reviewers:
ananta

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix Flash window in Analytics being incorrectly visible. The bug was that we accidentally marked a plugin widget as visible if it's parent was visible, even if it was explicitly set as hidden. BUG=8927 TEST=regression test included, also can verify that analytics doesn't display the gray rectangle per the bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15285

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -4 lines)			Patch
A	webkit/data/plugins/hidden_plugin.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	webkit/data/plugins/hidden_plugin_iframe.html	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/test/npapi_test_plugin.vcproj	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/test/plugin_client.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/test/plugin_test.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/glue/plugins/test/plugin_windowed_test.h	View		1 chunk	+22 lines, -0 lines	0 comments	Download
A	webkit/glue/plugins/test/plugin_windowed_test.cc	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
M	webkit/glue/webplugin_impl.cc	View		3 chunks	+10 lines, -4 lines	0 comments	Download
M	webkit/tools/test_shell/plugin_tests.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thanks for adding a nice test.

Expand Messages | Collapse Messages