Fix Flash window in Analytics being incorrectly visible....

webkit/glue/webplugin_impl.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "webkit/glue/webplugin_impl.h"
 
 #include "Cursor.h"
 #include "Document.h"
 #include "DocumentLoader.h"
@@ skipping 184 matching lines @@
   // our parent view was scrolled.
   impl_->setFrameRect(frameRect());
 }
 
 // We override this function, to make sure that geometry updates are sent
 // over to the plugin. For e.g. when a plugin is instantiated it does
 // not have a valid parent. As a result the first geometry update from
 // webkit is ignored. This function is called when the plugin eventually
 // gets a parent.
 void WebPluginContainer::setParentVisible(bool visible) {
+  if (isParentVisible() == visible)
+    return;  // No change.
+
   WebCore::Widget::setParentVisible(visible);
+  if (!isSelfVisible())
+    return;  // This widget has explicitely been marked as not visible.
+
   if (visible)
     show();
   else
     hide();
 }
 
 // We override this function so that if the plugin is windowed, we can call
 // NPP_SetWindow at the first possible moment.  This ensures that NPP_SetWindow
 // is called before the manual load data is sent to a plugin.  If this order is
 // reversed, Flash won't load videos.
@@ skipping 423 matching lines @@
   // the webview is closed.
   if (!webview->delegate()) {
     return;
   }
 
   WebCore::IntRect window_rect;
   WebCore::IntRect clip_rect;
   std::vector<gfx::Rect> cutout_rects;
   CalculateBounds(rect, &window_rect, &clip_rect, &cutout_rects);
 
-  // Notify the plugin that its parameters have changed.
-  delegate_->UpdateGeometry(webkit_glue::FromIntRect(window_rect),
-                            webkit_glue::FromIntRect(clip_rect));
-
   if (window_) {
     // Notify the window hosting the plugin (the WebViewDelegate) that
     // it needs to adjust the plugin, so that all the HWNDs can be moved
     // at the same time.
     WebPluginGeometry move;
     move.window = window_;
     move.window_rect = webkit_glue::FromIntRect(window_rect);
     move.clip_rect = webkit_glue::FromIntRect(clip_rect);
     move.cutout_rects = cutout_rects;
     move.visible = visible_;
 
     webview->delegate()->DidMove(webview, move);
   }
 
+  // Notify the plugin that its parameters have changed.
+  delegate_->UpdateGeometry(webkit_glue::FromIntRect(window_rect),
+                            webkit_glue::FromIntRect(clip_rect));
+
   // Initiate a download on the plugin url. This should be done for the
   // first update geometry sequence.
   if (first_geometry_update_) {
     first_geometry_update_ = false;
     // An empty url corresponds to an EMBED tag with no src attribute.
     if (!load_manually_ && plugin_url_.is_valid()) {
       HandleURLRequestInternal("GET", false, NULL, 0, NULL, false, false,
                                plugin_url_.spec().c_str(), NULL, false,
                                false);
     }
@@ skipping 737 matching lines @@
     client_index = clients_.erase(client_index);
     if (resource_client)
       resource_client->DidFail();
   }
 
   // This needs to be called now and not in the destructor since the
   // webframe_ might not be valid anymore.
   webframe_->set_plugin_delegate(NULL);
   webframe_ = NULL;
 }