Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10599002: Fix HTML5 video streaming. (Closed)

Created:
8 years, 6 months ago by darin (slow to review)
Modified:
8 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Fix HTML5 video streaming. AsyncResourceHandler was clearing the back-pointer stored on the request info prematurely. This caused us to miss many of the DataReceived_ACK messages. As a result, we'd get into a state where we'd never resume downloading. BUG=133808 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143341

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M content/browser/renderer_host/async_resource_handler.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/buffered_resource_handler.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/cross_site_resource_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_impl.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
darin (slow to review)
I'm working on a proper unit test for this, but since this CL fixes a ...
8 years, 6 months ago (2012-06-20 23:02:27 UTC) #1
darin (slow to review)
https://chromiumcodereview.appspot.com/10599002/diff/5/content/browser/renderer_host/buffered_resource_handler.cc File content/browser/renderer_host/buffered_resource_handler.cc (left): https://chromiumcodereview.appspot.com/10599002/diff/5/content/browser/renderer_host/buffered_resource_handler.cc#oldcode397 content/browser/renderer_host/buffered_resource_handler.cc:397: next_handler_ = handler.Pass(); NOTE: The old ResourceHandler gets destroyed ...
8 years, 6 months ago (2012-06-20 23:03:42 UTC) #2
jam
lgtm
8 years, 6 months ago (2012-06-20 23:16:49 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-20 23:41:28 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698