Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: content/renderer/render_view_impl.cc

Issue 10584042: Bring up a content settings icon for ungestured registerProtocolHandler call. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 16837b999eba5b00df72bfdb3b9f3f2e62772dfc..93ed5d2a8cd2f79137f3aee120dd3e28d0084107 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -5558,6 +5558,7 @@ void RenderViewImpl::registerProtocolHandler(const WebString& scheme,
if (base.GetOrigin() != absolute_url.GetOrigin()) {
return;
}
+ LOG(INFO) << "Got RPH in RenderViewImpl";
koz (OOO until 15th September) 2012/06/21 01:50:53 Don't forget to remove this.
Greg Billock 2012/06/21 19:59:11 I won't. There looks like a race bug, at least on
koz (OOO until 15th September) 2012/06/21 23:03:50 That's strange. I wonder if something changed rece
Greg Billock 2012/06/21 23:10:59 Yes. It was happening when I was testing the user
koz (OOO until 15th September) 2012/06/22 00:41:14 I'm not sure why this would be failing. Recently t
Greg Billock 2012/06/22 19:45:40 Looks like this is a prerendering thing. Proper th
Send(new ViewHostMsg_RegisterProtocolHandler(routing_id_,
UTF16ToUTF8(scheme),
absolute_url,

Powered by Google App Engine
This is Rietveld 408576698