Bring up a content settings icon for ungestured registerProtocolHandler call.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 5540 matching lines @@
                                              const WebString& base_url,
                                              const WebString& url,
                                              const WebString& title) {
   bool user_gesture = (webview()->focusedFrame() &&
                        webview()->focusedFrame()->isProcessingUserGesture());
   GURL base(base_url);
   GURL absolute_url = base.Resolve(UTF16ToUTF8(url));
   if (base.GetOrigin() != absolute_url.GetOrigin()) {
     return;
   }
+  LOG(INFO) << "Got RPH in RenderViewImpl";

[koz (OOO until 15th September), 2012/06/21 01:50:53]

Don't forget to remove this.

[Greg Billock, 2012/06/21 19:59:11]

I won't. There looks like a race bug, at least on linux. Without this line, an
ungestured RPH call in the page's onload() handler almost never gets through to
the browser to be handled. With this call, it almost always does get through. I
emailed Ben about this, but do you know how this can be fixed?

[koz (OOO until 15th September), 2012/06/21 23:03:50]

That's strange. I wonder if something changed recently in this area because RPH
is usually called onload() currently (eg: by calendar). Does it happen before
this patch?

[Greg Billock, 2012/06/21 23:10:59]

Yes. It was happening when I was testing the user gesture stuff, before any of
this.

On 2012/06/21 23:03:50, koz wrote:

[koz (OOO until 15th September), 2012/06/22 00:41:14]

I'm not sure why this would be failing. Recently the unit tests for this class
became really flaky on linux and chromeos, but I haven't seen any changes that
might have caused that.

[Greg Billock, 2012/06/22 19:45:40]

Looks like this is a prerendering thing. Proper threads/bugs opened.

   Send(new ViewHostMsg_RegisterProtocolHandler(routing_id_,
                                                UTF16ToUTF8(scheme),
                                                absolute_url,
                                                title,
                                                user_gesture));
 }
 
 WebKit::WebPageVisibilityState RenderViewImpl::visibilityState() const {
   WebKit::WebPageVisibilityState current_state = is_hidden() ?
       WebKit::WebPageVisibilityStateHidden :
@@ skipping 79 matching lines @@
 bool RenderViewImpl::WebWidgetHandlesCompositorScheduling() const {
   return !!RenderThreadImpl::current()->compositor_thread();
 }
 
 void RenderViewImpl::OnJavaBridgeInit() {
   DCHECK(!java_bridge_dispatcher_);
 #if defined(ENABLE_JAVA_BRIDGE)
   java_bridge_dispatcher_ = new JavaBridgeDispatcher(this);
 #endif
 }