Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2529)

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 10575014: Move process-per-site logic from BrowsingInstance to RenderProcessHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clean up RPHs in test. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_browser_tests.cc
diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc
index d0c359295707b2b473d5f6a88d20f1dacf6cd7ad..c6d6939a51a80fa214a81b9fbada31abb7266fb2 100644
--- a/chrome/browser/ssl/ssl_browser_tests.cc
+++ b/chrome/browser/ssl/ssl_browser_tests.cc
@@ -840,7 +840,7 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestRunsInsecureContentTwoTabs) {
test_server()->host_port_pair(),
&replacement_path));
- // Create a new tab in the same process.
+ // Create a new tab in the same process (since we are using process-per-site).
awong 2012/06/27 00:26:54 This parenthetical doesn't explain enough to me.
Charlie Reis 2012/06/27 20:53:43 Using the NEW_FOREGROUND_TAB disposition will not
GURL url = https_server_.GetURL(replacement_path);
browser::NavigateParams params(
browser(), url, content::PAGE_TRANSITION_TYPED);
@@ -853,6 +853,10 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestRunsInsecureContentTwoTabs) {
TabContents* tab2 = params.target_contents;
observer.Wait();
+ // Both tabs should have the same process.
+ EXPECT_EQ(tab1->web_contents()->GetRenderProcessHost(),
+ tab2->web_contents()->GetRenderProcessHost());
+
// The new tab has insecure content.
CheckAuthenticationBrokenState(tab2->web_contents(), 0, true, false);

Powered by Google App Engine
This is Rietveld 408576698