Move process-per-site logic from BrowsingInstance to RenderProcessHost.

chrome/browser/ssl/ssl_browser_tests.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
@@ skipping 822 matching lines @@
 
   // This tab should be fine.
   CheckAuthenticatedState(tab1->web_contents(), false);
 
   std::string replacement_path;
   ASSERT_TRUE(GetFilePathWithHostAndPortReplacement(
       "files/ssl/page_runs_insecure_content.html",
       test_server()->host_port_pair(),
       &replacement_path));
 
-  // Create a new tab in the same process.
+  // Create a new tab in the same process (since we are using process-per-site).

[awong, 2012/06/27 00:26:54]

This parenthetical doesn't explain enough to me.  If we were not using process
per site, how would the setup code look different?

[Charlie Reis, 2012/06/27 20:53:43]

Using the NEW_FOREGROUND_TAB disposition will not usually keep the new tab in a
new process by default.  It will work in process-per-site mode, though.  I've
updated the comment.

   GURL url = https_server_.GetURL(replacement_path);
   browser::NavigateParams params(
       browser(), url, content::PAGE_TRANSITION_TYPED);
   params.disposition = NEW_FOREGROUND_TAB;
   params.source_contents = tab1;
   ui_test_utils::WindowedNotificationObserver observer(
       content::NOTIFICATION_LOAD_STOP,
       content::NotificationService::AllSources());
   browser::Navigate(&params);
   TabContents* tab2 = params.target_contents;
   observer.Wait();
 
+  // Both tabs should have the same process.
+  EXPECT_EQ(tab1->web_contents()->GetRenderProcessHost(),
+            tab2->web_contents()->GetRenderProcessHost());
+
   // The new tab has insecure content.
   CheckAuthenticationBrokenState(tab2->web_contents(), 0, true, false);
 
   // Which means the origin for the first tab has also been contaminated with
   // insecure content.
   CheckAuthenticationBrokenState(tab1->web_contents(), 0, true, false);
 }
 
 // Visits a page with an image over http.  Visits another page over https
 // referencing that same image over http (hoping it is coming from the webcore
@@ skipping 583 matching lines @@
 
 // Visit a page over https that contains a frame with a redirect.
 
 // XMLHttpRequest insecure content in synchronous mode.
 
 // XMLHttpRequest insecure content in asynchronous mode.
 
 // XMLHttpRequest over bad ssl in synchronous mode.
 
 // XMLHttpRequest over OK ssl in synchronous mode.