Implement the linux debugger wire protocol.

Implement the linux debugger wire protocol.

Platform-dependent code of the Linux version of the debugger wire
protocol.
Committed: https://code.google.com/p/dart/source/detail?r=8913

[hausner, 2012-06-20 00:00:08]

Adding Devon and Keerti.

[siva, 2012-06-20 00:53:31]

lgtm

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
File runtime/bin/dbg_connection_linux.cc (right):

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
runtime/bin/dbg_connection_linux.cc:15: int
DebuggerConnectionImpl::wakeup_fds_[2] = {-1, -1};
It is not clear when epoll_fd_, wakeup_fds_ and listener_fd_ is closed.

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
runtime/bin/dbg_connection_linux.cc:65: result =
TEMP_FAILURE_RETRY(pipe(wakeup_fds_));
int result = TEMP....
instead of two lines.

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
runtime/bin/dbg_connection_linux.cc:87: // Register the wakeup_fd with the epoll
instance.
Register the listener_fd_ with the epoll instance.

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
runtime/bin/dbg_connection_linux.cc:106: 
wasted space.

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
File runtime/bin/dbg_connection_linux.h (right):

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
runtime/bin/dbg_connection_linux.h:7: 
extra blank line?

[hausner, 2012-06-20 16:05:58]

Thank you for the review Siva.

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
File runtime/bin/dbg_connection_linux.cc (right):

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
runtime/bin/dbg_connection_linux.cc:15: int
DebuggerConnectionImpl::wakeup_fds_[2] = {-1, -1};
On 2012/06/20 00:53:31, asiva wrote:
> It is not clear when epoll_fd_, wakeup_fds_ and listener_fd_ is closed.
They are currently never closed. The Socket class does not have a close
function. I'm adding a todo and will add a Socket::Close function later. It is
also needed in the platform-independent code in dbg_connection.cc.

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
runtime/bin/dbg_connection_linux.cc:65: result =
TEMP_FAILURE_RETRY(pipe(wakeup_fds_));
On 2012/06/20 00:53:31, asiva wrote:
> int result = TEMP....
> instead of two lines.

Done.

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
runtime/bin/dbg_connection_linux.cc:87: // Register the wakeup_fd with the epoll
instance.
On 2012/06/20 00:53:31, asiva wrote:
> Register the listener_fd_ with the epoll instance.

Done.

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
runtime/bin/dbg_connection_linux.cc:106: 
On 2012/06/20 00:53:31, asiva wrote:
> wasted space.

What, the empty line after the }  ?

I'll add a TODO to remove the empty line :)

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
File runtime/bin/dbg_connection_linux.h (right):

http://codereview.chromium.org/10572028/diff/1/runtime/bin/dbg_connection_lin...
runtime/bin/dbg_connection_linux.h:7: 
On 2012/06/20 00:53:31, asiva wrote:
> extra blank line?

Done.