Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10565009: (Finally) Remove NetLog::EventParameters. (Closed)

Created:
8 years, 6 months ago by mmenke
Modified:
8 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, darin-cc_chromium.org
Visibility:
Public.

Description

(Finally) Remove NetLog::EventParameters. R=eroman@chromium.org BUG=126243 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142953

Patch Set 1 #

Patch Set 2 : Missed a file. Will the madness ever end? #

Total comments: 2

Patch Set 3 : Remove header #

Patch Set 4 : Remove another header #

Patch Set 5 : #

Patch Set 6 : Fix a couple more files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -203 lines) Patch
M net/base/file_stream_posix.cc View 1 2 3 4 5 chunks +6 lines, -6 lines 0 comments Download
M net/base/net_log.h View 1 2 3 4 6 chunks +0 lines, -117 lines 0 comments Download
M net/base/net_log.cc View 1 2 3 4 5 chunks +0 lines, -80 lines 0 comments Download
M net/http/http_request_headers_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/gdig/file_net_log.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mmenke
I'll want to run this through all the trybots (linux, mac, android, chromeos) once the ...
8 years, 6 months ago (2012-06-15 20:09:30 UTC) #1
eroman
lgtm http://codereview.chromium.org/10565009/diff/7001/net/base/net_log.h File net/base/net_log.h (right): http://codereview.chromium.org/10565009/diff/7001/net/base/net_log.h#newcode14 net/base/net_log.h:14: #include "base/memory/ref_counted.h" is this still needed?
8 years, 6 months ago (2012-06-16 01:19:15 UTC) #2
mmenke
http://codereview.chromium.org/10565009/diff/7001/net/base/net_log.h File net/base/net_log.h (right): http://codereview.chromium.org/10565009/diff/7001/net/base/net_log.h#newcode14 net/base/net_log.h:14: #include "base/memory/ref_counted.h" On 2012/06/16 01:19:15, eroman wrote: > is ...
8 years, 6 months ago (2012-06-16 02:09:25 UTC) #3
mmenke
Thanks so much for all the speedy reviews.
8 years, 6 months ago (2012-06-16 02:20:23 UTC) #4
eroman
Thanks for making this change :)
8 years, 6 months ago (2012-06-16 23:54:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10565009/1006
8 years, 6 months ago (2012-06-19 05:57:49 UTC) #6
commit-bot: I haz the power
Try job failure for 10565009-1006 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-19 06:12:46 UTC) #7
mmenke
On 2012/06/19 06:12:46, I haz the power (commit-bot) wrote: > Try job failure for 10565009-1006 ...
8 years, 6 months ago (2012-06-19 13:19:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10565009/12004
8 years, 6 months ago (2012-06-19 13:20:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10565009/19004
8 years, 6 months ago (2012-06-19 13:30:07 UTC) #10
commit-bot: I haz the power
8 years, 6 months ago (2012-06-19 14:58:37 UTC) #11
Change committed as 142953

Powered by Google App Engine
This is Rietveld 408576698