Issue 10563005: fix mapping of html files to libraries http://code.google.com/p/dart/issues/detail?id=3586

Issue 10563005: fix mapping of html files to libraries http://code.google.com/p/dart/issues/detail?id=3586 (Closed)

Created:
8 years, 6 months ago by keertip

Modified:
8 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

fix mapping of html files to libraries http://code.google.com/p/dart/issues/detail?id=3586 Committed: https://code.google.com/p/dart/source/detail?r=8729

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -34 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartLibraryImpl.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartProjectImpl.java	View	3 chunks	+7 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/HTMLFileImpl.java	View	2 chunks	+7 lines, -2 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/delta/DeltaProcessor.java	View	4 chunks	+31 lines, -29 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/resource/IResourceUtilities.java	View	1 chunk	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

keertip

Changed the mapping to use the location of the library instead of just the file ...

8 years, 6 months ago (2012-06-15 16:56:13 UTC) #1

Brian Wilkerson

LGTM http://codereview.chromium.org/10563005/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/HTMLFileImpl.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/HTMLFileImpl.java (right): http://codereview.chromium.org/10563005/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/HTMLFileImpl.java#newcode2 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/HTMLFileImpl.java:2: * Copyright (c) 2011, the Dart project authors. ...

8 years, 6 months ago (2012-06-15 17:57:00 UTC) #2

keertip

8 years, 6 months ago (2012-06-15 18:09:49 UTC) #3

http://codereview.chromium.org/10563005/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/HTMLFileImpl.java
(right):

http://codereview.chromium.org/10563005/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/HTMLFileImpl.java:2:
* Copyright (c) 2011, the Dart project authors.
On 2012/06/15 17:57:00, Brian Wilkerson wrote:
> nit: copyright year

Done.

Expand Messages | Collapse Messages