Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: src/splay-tree.h

Issue 10556038: Fix MSVC warning about missing operator delete. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/list.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/splay-tree.h
diff --git a/src/splay-tree.h b/src/splay-tree.h
index 388f9b5429f889bc7aebcefaf90ba543a7f3178d..4b7ddc8ff2952186090d2dbb0281cd662b416a62 100644
--- a/src/splay-tree.h
+++ b/src/splay-tree.h
@@ -69,6 +69,10 @@ class SplayTree {
INLINE(void operator delete(void* p, size_t)) {
Jakob Kummerow 2012/06/18 12:08:41 "delete" operators don't take "size" arguments. Th
AllocationPolicy::Delete(p);
}
+ // Please the MSVC compiler. We should never have to execute this.
+ INLINE(void operator delete(void* p, size_t size, AllocationPolicy policy)) {
Jakob Kummerow 2012/06/18 12:08:41 same here
+ UNREACHABLE();
+ }
// Inserts the given key in this tree with the given value. Returns
// true if a node was inserted, otherwise false. If found the locator
@@ -122,6 +126,11 @@ class SplayTree {
INLINE(void operator delete(void* p, size_t)) {
Jakob Kummerow 2012/06/18 12:08:41 same here
return AllocationPolicy::Delete(p);
}
+ // Please the MSVC compiler. We should never have to execute
+ // this.
+ INLINE(void operator delete(void* p, size_t, AllocationPolicy allocator)) {
Jakob Kummerow 2012/06/18 12:08:41 same here
+ UNREACHABLE();
+ }
Key key() { return key_; }
Value value() { return value_; }
« no previous file with comments | « src/list.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698