Fix MSVC warning about missing operator delete.

src/splay-tree.h

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 48 matching lines @@
   class Locator;
 
   SplayTree(AllocationPolicy allocator = AllocationPolicy())
       : root_(NULL), allocator_(allocator) { }
   ~SplayTree();
 
   INLINE(void* operator new(size_t size,
                             AllocationPolicy allocator = AllocationPolicy())) {
     return allocator.New(static_cast<int>(size));
   }
   INLINE(void operator delete(void* p, size_t)) {

[Jakob Kummerow, 2012/06/18 12:08:41]

"delete" operators don't take "size" arguments. This line should be:
INLINE(void operator delete(void* p)) {

     AllocationPolicy::Delete(p);
   }
+  // Please the MSVC compiler.  We should never have to execute this.
+  INLINE(void operator delete(void* p, size_t size, AllocationPolicy policy)) {

[Jakob Kummerow, 2012/06/18 12:08:41]

same here

+    UNREACHABLE();
+  }
 
   // Inserts the given key in this tree with the given value.  Returns
   // true if a node was inserted, otherwise false.  If found the locator
   // is enabled and provides access to the mapping for the key.
   bool Insert(const Key& key, Locator* locator);
 
   // Looks up the key in this tree and returns true if it was found,
   // otherwise false.  If the node is found the locator is enabled and
   // provides access to the mapping for the key.
   bool Find(const Key& key, Locator* locator);
@@ skipping 30 matching lines @@
    public:
     Node(const Key& key, const Value& value)
         : key_(key),
           value_(value),
           left_(NULL),
           right_(NULL) { }
 
     INLINE(void* operator new(size_t size, AllocationPolicy allocator)) {
       return allocator.New(static_cast<int>(size));
     }
     INLINE(void operator delete(void* p, size_t)) {

[Jakob Kummerow, 2012/06/18 12:08:41]

same here

       return AllocationPolicy::Delete(p);
     }
+    // Please the MSVC compiler.  We should never have to execute
+    // this.
+    INLINE(void operator delete(void* p, size_t, AllocationPolicy allocator)) {

[Jakob Kummerow, 2012/06/18 12:08:41]

same here

+      UNREACHABLE();
+    }
 
     Key key() { return key_; }
     Value value() { return value_; }
     Node* left() { return left_; }
     Node* right() { return right_; }
 
    private:
     friend class SplayTree;
     friend class Locator;
     Key key_;
@@ skipping 65 matching lines @@
   Node* root_;
   AllocationPolicy allocator_;
 
   DISALLOW_COPY_AND_ASSIGN(SplayTree);
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_SPLAY_TREE_H_