Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: remoting/protocol/connection_to_client.cc

Issue 10556020: Cleaned up the reader and writer create methods to return scoped_ptr. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/connection_to_client.cc
diff --git a/remoting/protocol/connection_to_client.cc b/remoting/protocol/connection_to_client.cc
index ce8cbdba44df3695979ea38a2778a7b7820fbbef..b25b647b73b1bb1e80e1d18aec17787638673aea 100644
--- a/remoting/protocol/connection_to_client.cc
+++ b/remoting/protocol/connection_to_client.cc
@@ -116,7 +116,8 @@ void ConnectionToClient::OnSessionStateChange(Session::State state) {
event_dispatcher_->set_sequence_number_callback(base::Bind(
&ConnectionToClient::UpdateSequenceNumber, base::Unretained(this)));
- video_writer_.reset(VideoWriter::Create(session_->config()));
+ video_writer_.reset();
Sergey Ulanov 2012/06/15 20:41:43 You don't need to reset it here. The assignment sh
kxing 2012/06/15 20:48:17 Done.
+ video_writer_ = VideoWriter::Create(session_->config());
video_writer_->Init(session_.get(), base::Bind(
&ConnectionToClient::OnChannelInitialized, base::Unretained(this)));

Powered by Google App Engine
This is Rietveld 408576698