Remove BrowserList::GetLastActive usage from WebUI pages.

chrome/browser/ui/webui/certificate_viewer_webui.cc

Index: chrome/browser/ui/webui/certificate_viewer_webui.cc
===================================================================
--- chrome/browser/ui/webui/certificate_viewer_webui.cc	(revision 142088)
+++ chrome/browser/ui/webui/certificate_viewer_webui.cc	(working copy)
@@ -13,7 +13,7 @@
 #include "chrome/browser/certificate_viewer.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/certificate_dialogs.h"
 #include "chrome/browser/ui/constrained_window.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
@@ -69,9 +69,8 @@
 }
 
 void CertificateViewerDialog::Show(gfx::NativeWindow parent) {
-  // TODO(oshima): Should get browser from parent.
-  Browser* browser = BrowserList::GetLastActive();
-  DCHECK(browser);
+  Browser* browser =
+      browser::FindBrowserWithWebContents(web_ui()->GetWebContents());

[Ben Goodger (Google), 2012/06/15 20:15:44]

so, this method is pretty much just as bad as GLA. it'd be interesting to figure
out what we're actually trying to do here... looks like you could get away with
using web_ui()->GetWebContents().

   TabContents* current_tab_contents = browser->GetActiveTabContents();
   // TODO(bshe): UI tweaks needed for AURA html Dialog, such as add padding on
   // title for AURA ConstrainedWebDialogUI.