Remove BrowserList::GetLastActive usage from WebUI pages.

chrome/browser/ui/webui/certificate_viewer_webui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/certificate_viewer_webui.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/i18n/time_formatting.h"
 #include "base/json/json_writer.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/certificate_viewer.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/certificate_dialogs.h"
 #include "chrome/browser/ui/constrained_window.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
 #include "chrome/common/net/x509_certificate_model.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/web_contents.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/web_dialogs/constrained_web_dialog_ui.h"
 #include "ui/web_dialogs/web_dialog_observer.h"
@@ skipping 35 matching lines @@
   x509_certificate_model::GetCertChainFromCert(cert_->os_cert_handle(),
       &cert_chain);
   title_ = l10n_util::GetStringFUTF16(IDS_CERT_INFO_DIALOG_TITLE,
       UTF8ToUTF16(x509_certificate_model::GetTitle(cert_chain.front())));
 }
 
 CertificateViewerDialog::~CertificateViewerDialog() {
 }
 
 void CertificateViewerDialog::Show(gfx::NativeWindow parent) {
-  // TODO(oshima): Should get browser from parent.
-  Browser* browser = BrowserList::GetLastActive();
-  DCHECK(browser);
+  Browser* browser =
+      browser::FindBrowserWithWebContents(web_ui()->GetWebContents());

[Ben Goodger (Google), 2012/06/15 20:15:44]

so, this method is pretty much just as bad as GLA. it'd be interesting to figure
out what we're actually trying to do here... looks like you could get away with
using web_ui()->GetWebContents().

   TabContents* current_tab_contents = browser->GetActiveTabContents();
   // TODO(bshe): UI tweaks needed for AURA html Dialog, such as add padding on
   // title for AURA ConstrainedWebDialogUI.
   window_ = ui::CreateConstrainedWebDialog(
       current_tab_contents->profile(),
       this,
       NULL,
       current_tab_contents)->window()->GetNativeWindow();
 }
 
@@ skipping 326 matching lines @@
     const base::ListValue* args) const {
   int cert_index;
   double val;
   if (!(args->GetDouble(0, &val)))
     return -1;
   cert_index = static_cast<int>(val);
   if (cert_index < 0 || cert_index >= static_cast<int>(cert_chain_.size()))
     return -1;
   return cert_index;
 }