Handle interface to prerenders.

chrome/browser/prerender/prerender_link_manager.h

Index: chrome/browser/prerender/prerender_link_manager.h
diff --git a/chrome/browser/prerender/prerender_link_manager.h b/chrome/browser/prerender/prerender_link_manager.h
index aacee8bc4cdb08b906d4190ff9f760065afba0ef..c5063a266a5f2c281a89d5ed9d473ed60b519861 100644
--- a/chrome/browser/prerender/prerender_link_manager.h
+++ b/chrome/browser/prerender/prerender_link_manager.h
@@ -26,6 +26,7 @@ class Size;
 
 namespace prerender {
 
+  class PrerenderHandle;

[dominich, 2012/07/02 20:43:03]

nit: indent

[gavinp, 2012/07/03 16:41:02]

Done.

 class PrerenderManager;
 
 // PrerenderLinkManager implements the API on Link elements for all documents
@@ -70,14 +71,15 @@ class PrerenderLinkManager : public ProfileKeyedService {
   friend class PrerenderTest;
 
   typedef std::pair<int, int> ChildAndPrerenderIdPair;
-  typedef std::map<ChildAndPrerenderIdPair, GURL> IdPairToUrlMap;
+  typedef std::map<ChildAndPrerenderIdPair, PrerenderHandle*>

[dominich, 2012/07/02 20:43:03]

why isn't this a WeakPtr? could the reference be removed before it's removed
from the map, and could this then be a dangling pointer?

[gavinp, 2012/07/03 16:41:02]

No, it owns it. Made it a linked_ptr<> so that's clear.

[dominich, 2012/07/03 17:08:39]

I think a comment stating ownership would be better than a linked_ptr.
Linked_ptr doesn't scream ownership to me, it screams refcounting. Which is
unnecessary here.

[gavinp, 2012/07/03 18:45:40]

Done.

+      IdPairToPrerenderHandleMap;
 
-  void RemovePrerender(const IdPairToUrlMap::iterator& id_url_iter);
+  void RemovePrerender(const IdPairToPrerenderHandleMap::iterator& id_url_iter);
 
   bool IsEmpty() const;
 
   PrerenderManager* manager_;
-  IdPairToUrlMap ids_to_url_map_;
+  IdPairToPrerenderHandleMap ids_to_handle_map_;
 
   DISALLOW_COPY_AND_ASSIGN(PrerenderLinkManager);
 };