Handle interface to prerenders.

chrome/browser/prerender/prerender_link_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PRERENDER_PRERENDER_LINK_MANAGER_H_
 #define CHROME_BROWSER_PRERENDER_PRERENDER_LINK_MANAGER_H_
 #pragma once
 
 #include <map>
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "chrome/browser/profiles/profile_keyed_service.h"
 #include "googleurl/src/gurl.h"
 
 class Profile;
 
 namespace content {
 struct Referrer;
 }
 
 namespace gfx {
 class Size;
 }
 
 namespace prerender {
 
+  class PrerenderHandle;

[dominich, 2012/07/02 20:43:03]

nit: indent

[gavinp, 2012/07/03 16:41:02]

Done.

 class PrerenderManager;
 
 // PrerenderLinkManager implements the API on Link elements for all documents
 // being rendered in this chrome instance.  It receives messages from the
 // renderer indicating addition, cancelation and abandonment of link elements,
 // and controls the PrerenderManager accordingly.
 class PrerenderLinkManager : public ProfileKeyedService {
  public:
   explicit PrerenderLinkManager(PrerenderManager* manager);
   virtual ~PrerenderLinkManager();
@@ skipping 24 matching lines @@
 
   // If a renderer channel closes (crash, fast exit, etc...), that's effectively
   // an abandon of any prerenders launched by that child.
   void OnChannelClosing(int child_id);
 
  private:
   friend class PrerenderBrowserTest;
   friend class PrerenderTest;
 
   typedef std::pair<int, int> ChildAndPrerenderIdPair;
-  typedef std::map<ChildAndPrerenderIdPair, GURL> IdPairToUrlMap;
+  typedef std::map<ChildAndPrerenderIdPair, PrerenderHandle*>

[dominich, 2012/07/02 20:43:03]

why isn't this a WeakPtr? could the reference be removed before it's removed
from the map, and could this then be a dangling pointer?

[gavinp, 2012/07/03 16:41:02]

No, it owns it. Made it a linked_ptr<> so that's clear.

[dominich, 2012/07/03 17:08:39]

I think a comment stating ownership would be better than a linked_ptr.
Linked_ptr doesn't scream ownership to me, it screams refcounting. Which is
unnecessary here.

[gavinp, 2012/07/03 18:45:40]

Done.

+      IdPairToPrerenderHandleMap;
 
-  void RemovePrerender(const IdPairToUrlMap::iterator& id_url_iter);
+  void RemovePrerender(const IdPairToPrerenderHandleMap::iterator& id_url_iter);
 
   bool IsEmpty() const;
 
   PrerenderManager* manager_;
-  IdPairToUrlMap ids_to_url_map_;
+  IdPairToPrerenderHandleMap ids_to_handle_map_;
 
   DISALLOW_COPY_AND_ASSIGN(PrerenderLinkManager);
 };
 
 }  // namespace prerender
 
 #endif  // CHROME_BROWSER_PRERENDER_PRERENDER_LINK_MANAGER_H_