Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: chrome/browser/prerender/prerender_link_manager.h

Issue 10553029: Handle interface to prerenders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: some remediation, and deflaking browser tests. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_link_manager.h
diff --git a/chrome/browser/prerender/prerender_link_manager.h b/chrome/browser/prerender/prerender_link_manager.h
index aacee8bc4cdb08b906d4190ff9f760065afba0ef..7e9a5e4251af296086461a23a86a0e519c8c095b 100644
--- a/chrome/browser/prerender/prerender_link_manager.h
+++ b/chrome/browser/prerender/prerender_link_manager.h
@@ -26,6 +26,7 @@ class Size;
namespace prerender {
+class PrerenderHandle;
class PrerenderManager;
// PrerenderLinkManager implements the API on Link elements for all documents
@@ -70,14 +71,19 @@ class PrerenderLinkManager : public ProfileKeyedService {
friend class PrerenderTest;
typedef std::pair<int, int> ChildAndPrerenderIdPair;
- typedef std::map<ChildAndPrerenderIdPair, GURL> IdPairToUrlMap;
+ typedef std::map<ChildAndPrerenderIdPair, PrerenderHandle*>
+ IdPairToPrerenderHandleMap;
- void RemovePrerender(const IdPairToUrlMap::iterator& id_url_iter);
+ void RemovePrerender(const IdPairToPrerenderHandleMap::iterator& id_url_iter);
gavinp 2012/07/11 17:04:00 Apparently, I was thinking about this function too
bool IsEmpty() const;
PrerenderManager* manager_;
- IdPairToUrlMap ids_to_url_map_;
+
+ // Map giving, per child process, for each prerender_id, the PrerenderHandle.
mmenke 2012/07/09 18:06:57 nit: prerender id (prerender_id is not a type, bu
mmenke 2012/07/09 18:06:57 nit: I find this sentence rather hard to follow.
gavinp 2012/07/11 17:04:00 Done.
+ // This map owns the PrerenderHandle, and so when erasing, you should delete
+ // the handle too.
+ IdPairToPrerenderHandleMap ids_to_handle_map_;
DISALLOW_COPY_AND_ASSIGN(PrerenderLinkManager);
};

Powered by Google App Engine
This is Rietveld 408576698