Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: content/public/browser/session_storage_namespace.h

Issue 10546167: Create and store persistent unique ids for sessionStorage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/session_storage_namespace.h
diff --git a/content/public/browser/session_storage_namespace.h b/content/public/browser/session_storage_namespace.h
index 5b17d0ceaebd56e8c45794931e5525c6d17d47f8..4b950e101f08483478b8e59a5da903bbda3562db 100644
--- a/content/public/browser/session_storage_namespace.h
+++ b/content/public/browser/session_storage_namespace.h
@@ -6,16 +6,19 @@
#define CONTENT_PUBLIC_BROWSER_SESSION_STORAGE_NAMESPACE_H_
#pragma once
+#include <string>
+
#include "base/memory/ref_counted.h"
namespace content {
// This is a ref-counted class that represents a SessionStorageNamespace.
// On destruction it ensures that the storage namespace is destroyed.
-// NOTE: That if we're shutting down, we don't strictly need to do this, but
-// it keeps valgrind happy.
class SessionStorageNamespace
: public base::RefCountedThreadSafe<SessionStorageNamespace> {
+ public:
+ virtual int64 id() const = 0;
jochen (gone - plz use gerrit) 2012/06/15 13:57:21 can you please document these two getters? also,
marja 2012/06/15 14:31:32 Added docs: // Returns the ID of the |SessionSto
+ virtual const std::string& persistent_id() const = 0;
protected:
jochen (gone - plz use gerrit) 2012/06/15 13:57:21 empty line before protected
marja 2012/06/15 14:31:32 Done.
friend class base::RefCountedThreadSafe<SessionStorageNamespace>;
virtual ~SessionStorageNamespace() {}

Powered by Google App Engine
This is Rietveld 408576698