content/public/browser/session_storage_namespace.h - Issue 10546167: Create and store persistent unique ids for sessionStorage.

Side by Side Diff: content/public/browser/session_storage_namespace.h

Issue 10546167: Create and store persistent unique ids for sessionStorage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/dom_storage/session_storage_namespace_impl.cc ('K') | « content/browser/dom_storage/session_storage_namespace_impl.cc ('k') | webkit/dom_storage/dom_storage_area.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_PUBLIC_BROWSER_SESSION_STORAGE_NAMESPACE_H_	5 #ifndef CONTENT_PUBLIC_BROWSER_SESSION_STORAGE_NAMESPACE_H_

6 #define CONTENT_PUBLIC_BROWSER_SESSION_STORAGE_NAMESPACE_H_	6 #define CONTENT_PUBLIC_BROWSER_SESSION_STORAGE_NAMESPACE_H_

7 #pragma once	7 #pragma once

8	8

	9 #include <string>

	10

9 #include "base/memory/ref_counted.h"	11 #include "base/memory/ref_counted.h"

10	12

11 namespace content {	13 namespace content {

12	14

13 // This is a ref-counted class that represents a SessionStorageNamespace.	15 // This is a ref-counted class that represents a SessionStorageNamespace.

14 // On destruction it ensures that the storage namespace is destroyed.	16 // On destruction it ensures that the storage namespace is destroyed.

15 // NOTE: That if we're shutting down, we don't strictly need to do this, but

16 // it keeps valgrind happy.

17 class SessionStorageNamespace	17 class SessionStorageNamespace

18 : public base::RefCountedThreadSafe<SessionStorageNamespace> {	18 : public base::RefCountedThreadSafe<SessionStorageNamespace> {

	19 public:

	20 virtual int64 id() const = 0;
	jochen (gone - plz use gerrit) 2012/06/15 13:57:21 can you please document these two getters? also, can you please document these two getters? also, currently you're not using them outside of content/. Will that change? Otherwise, the getters should not be on the public interface. marja 2012/06/15 14:31:32 Added docs: // Returns the ID of the \|SessionSto Show quoted text On 2012/06/15 13:57:21, jochen wrote: > can you please document these two getters? > > also, currently you're not using them outside of content/. Will that change? > Otherwise, the getters should not be on the public interface. Added docs: // Returns the ID of the \|SessionStorageNamespace\|. The ID is unique among all // SessionStorageNamespace objects, but not unique across browser runs. // Returns the persistent ID for the \|SessionStorageNamespace\|. The ID is // unique across browser runs. They'll be used outside content.
	21 virtual const std::string& persistent_id() const = 0;

19 protected:	22 protected:
	jochen (gone - plz use gerrit) 2012/06/15 13:57:21 empty line before protected empty line before protected marja 2012/06/15 14:31:32 Done. Show quoted text On 2012/06/15 13:57:21, jochen wrote: > empty line before protected Done.
20 friend class base::RefCountedThreadSafe<SessionStorageNamespace>;	23 friend class base::RefCountedThreadSafe<SessionStorageNamespace>;

21 virtual ~SessionStorageNamespace() {}	24 virtual ~SessionStorageNamespace() {}

22 };	25 };
	jochen (gone - plz use gerrit) 2012/06/15 13:57:21 disallow copy/assign disallow copy/assign marja 2012/06/15 14:31:32 Done. Show quoted text On 2012/06/15 13:57:21, jochen wrote: > disallow copy/assign Done. marja 2012/06/20 16:45:25 michaeln says here https://chromiumcodereview.apps Show quoted text On 2012/06/15 14:31:32, marja wrote: > On 2012/06/15 13:57:21, jochen wrote: > > disallow copy/assign > > Done. michaeln says here https://chromiumcodereview.appspot.com/10572015/ that we shouldn't DISALLOW_.. for abstract classes. This class has no member variables either, so conceptually copying/assigning it is a no op, and we could just allow it..
23	26

24 } // namespace content	27 } // namespace content

25	28

26 #endif // CONTENT_PUBLIC_BROWSER_SESSION_STORAGE_NAMESPACE_H_	29 #endif // CONTENT_PUBLIC_BROWSER_SESSION_STORAGE_NAMESPACE_H_

OLD	NEW