NetLogEventParameter to Callback refactoring 4.

NetLogEventParameter to Callback refactoring 4.
Get rid of all uses of NetLogEventParameters in net/udp and
net/dns.

R=eroman@chromium.org
BUG=126243
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142076

[eroman, 2012-06-13 18:39:41]

lgtm

http://codereview.chromium.org/10546133/diff/8012/net/udp/udp_net_log_paramet...
File net/udp/udp_net_log_parameters.h (right):

http://codereview.chromium.org/10546133/diff/8012/net/udp/udp_net_log_paramet...
net/udp/udp_net_log_parameters.h:5: #ifndef NET_UDP_UDP_DATA_TRANSFER_PARAM_H_
Update for new path

http://codereview.chromium.org/10546133/diff/8012/net/udp/udp_socket_libevent.cc
File net/udp/udp_socket_libevent.cc (left):

http://codereview.chromium.org/10546133/diff/8012/net/udp/udp_socket_libevent...
net/udp/udp_socket_libevent.cc:52: if (source.is_valid())
Do you know what this is about? (the new code doesn't check for it)

http://codereview.chromium.org/10546133/diff/8012/net/udp/udp_socket_win.cc
File net/udp/udp_socket_win.cc (left):

http://codereview.chromium.org/10546133/diff/8012/net/udp/udp_socket_win.cc#o...
net/udp/udp_socket_win.cc:56: if (source.is_valid())
same question

[mmenke, 2012-06-13 19:43:44]

http://codereview.chromium.org/10546133/diff/8012/net/udp/udp_net_log_paramet...
File net/udp/udp_net_log_parameters.h (right):

http://codereview.chromium.org/10546133/diff/8012/net/udp/udp_net_log_paramet...
net/udp/udp_net_log_parameters.h:5: #ifndef NET_UDP_UDP_DATA_TRANSFER_PARAM_H_
On 2012/06/13 18:39:41, eroman wrote:
> Update for new path

Done.  Guess the presubmit check doesn't like renames.

http://codereview.chromium.org/10546133/diff/8012/net/udp/udp_socket_libevent.cc
File net/udp/udp_socket_libevent.cc (left):

http://codereview.chromium.org/10546133/diff/8012/net/udp/udp_socket_libevent...
net/udp/udp_socket_libevent.cc:52: if (source.is_valid())
On 2012/06/13 18:39:41, eroman wrote:
> Do you know what this is about? (the new code doesn't check for it)

When a UDP socket is created by an object outside net, the source won't be
valid.  NetLogSourceParameter::ToValue() returns NULL in this case, so it's not
needed.  It looks like I forgot to copy this behavior in
SourceEventParametersCallback, so I'll go ahead and add it in another CL.

http://codereview.chromium.org/10546133/diff/8012/net/udp/udp_socket_win.cc
File net/udp/udp_socket_win.cc (left):

http://codereview.chromium.org/10546133/diff/8012/net/udp/udp_socket_win.cc#o...
net/udp/udp_socket_win.cc:56: if (source.is_valid())
On 2012/06/13 18:39:41, eroman wrote:
> same question

Same answer.

[commit-bot: I haz the power, 2012-06-13 22:15:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/10546133/8014

[commit-bot: I haz the power, 2012-06-13 22:15:59]

Failed to apply patch for net/udp/udp_net_log_parameters.cc:
While running patch -p0 --forward --force;
patching file net/udp/udp_net_log_parameters.cc
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file
net/udp/udp_net_log_parameters.cc.rej

[commit-bot: I haz the power, 2012-06-13 22:29:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/10546133/7007

[commit-bot: I haz the power, 2012-06-13 22:29:07]

Failed to apply patch for net/udp/udp_net_log_parameters.cc:
While running patch -p0 --forward --force;
patching file net/udp/udp_net_log_parameters.cc
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file
net/udp/udp_net_log_parameters.cc.rej

[mmenke, 2012-06-13 22:48:07]

On 2012/06/13 22:29:07, I haz the power (commit-bot) wrote:
> Failed to apply patch for net/udp/udp_net_log_parameters.cc:
> While running patch -p0 --forward --force;
> patching file net/udp/udp_net_log_parameters.cc
> Hunk #1 FAILED at 2.
> 1 out of 1 hunk FAILED -- saving rejects to file
> net/udp/udp_net_log_parameters.cc.rej

Really doesn't like that rename.  I'll land manually after it passes the
trybots.