Add test for buffered file input stream on dart:io File class.

Add test for buffered file input stream on dart:io File class.


BUG=
TEST=standalone/io/file_test

Committed: https://code.google.com/p/dart/source/detail?r=8643

[Anders Johnsen, 2012-06-13 12:51:31]

http://codereview.chromium.org/10544134/diff/1/tests/standalone/io/file_test....
File tests/standalone/io/file_test.dart (right):

http://codereview.chromium.org/10544134/diff/1/tests/standalone/io/file_test....
tests/standalone/io/file_test.dart:168: static void
testReadWriteStreamLargeFile() {
We should also test the case of using pipe:

InputStream input = inputFile.openInputStream();
OutputStream output = outputFile.openOutputStream();
input.pipe(output);

http://codereview.chromium.org/10544134/diff/1/tests/standalone/io/file_test....
tests/standalone/io/file_test.dart:172:
tempDirectory.path.concat("/out_read_write_stream_large_file");
What about using Options.executable?

http://codereview.chromium.org/10544134/diff/1/tests/standalone/io/file_test....
tests/standalone/io/file_test.dart:177: buffer[i] = i % 25 + 97;  // The letters
a through y.
I don't think we should restrict it to normal characters, as it should work with
binary data as well.

http://codereview.chromium.org/10544134/diff/1/tests/standalone/io/file_test....
tests/standalone/io/file_test.dart:180: Expect.equals(false, writeDone);
We can not assume this.

http://codereview.chromium.org/10544134/diff/1/tests/standalone/io/file_test....
tests/standalone/io/file_test.dart:204: Expect.equals(0, input.available());
The tests here, and below, could be moved to a isolated test function. I really
like it, but moving it out would make it easier to read and more explicit that
you do test this.

[Bill Hesse, 2012-06-13 14:18:46]

Added a test of .pipe.  Addressed comments.  This now also fixes the bug that
manifested when the buffer size was set to 100 - tests now all work with an
internal buffer size of 100,  as well as 64 KB.

http://codereview.chromium.org/10544134/diff/1/tests/standalone/io/file_test....
File tests/standalone/io/file_test.dart (right):

http://codereview.chromium.org/10544134/diff/1/tests/standalone/io/file_test....
tests/standalone/io/file_test.dart:172:
tempDirectory.path.concat("/out_read_write_stream_large_file");
On 2012/06/13 12:51:31, ajohnsen wrote:
> What about using Options.executable?

This also tests outputStream, and fits in with the other tests in the file, and
we know what to compare it with.

http://codereview.chromium.org/10544134/diff/1/tests/standalone/io/file_test....
tests/standalone/io/file_test.dart:177: buffer[i] = i % 25 + 97;  // The letters
a through y.
On 2012/06/13 12:51:31, ajohnsen wrote:
> I don't think we should restrict it to normal characters, as it should work
with
> binary data as well.

Done.

http://codereview.chromium.org/10544134/diff/1/tests/standalone/io/file_test....
tests/standalone/io/file_test.dart:180: Expect.equals(false, writeDone);
On 2012/06/13 12:51:31, ajohnsen wrote:
> We can not assume this.
I guess not.  Though it is true in this case.

http://codereview.chromium.org/10544134/diff/1/tests/standalone/io/file_test....
tests/standalone/io/file_test.dart:204: Expect.equals(0, input.available());
It is really not a natural test, "All read but not closed yet", and in one case,
we test that it is closed.  So these two lines don't really fit in a function. 
And the input closed test is sometimes moved to a different position relative to
the available test.

On 2012/06/13 12:51:31, ajohnsen wrote:
> The tests here, and below, could be moved to a isolated test function. I
really
> like it, but moving it out would make it easier to read and more explicit that
> you do test this.

[Anders Johnsen, 2012-06-14 06:13:05]

LGTM