Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 10544104: Add more testing to trusted graphics_3d. (Closed)

Created:
8 years, 6 months ago by nfullagar
Modified:
8 years, 6 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Add more testing to trusted graphics_3d. - Add a test to use OpenGLES C API directly. - Add a test calling a couple extensions, if glGetString reports availability. - Add #include <GLES2/gl2.h> and <GLES2/gl2ext.h> to test. BUG=none TEST=ppapi/test_graphics_3d Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142250

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -8 lines) Patch
M ppapi/ppapi_sources.gypi View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/tests/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/test_graphics_3d.h View 1 2 3 4 5 6 1 chunk +6 lines, -3 lines 0 comments Download
M ppapi/tests/test_graphics_3d.cc View 1 2 3 4 5 6 4 chunks +101 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nfullagar
8 years, 6 months ago (2012-06-13 17:57:33 UTC) #1
viettrungluu
Should these tests be run from ppapi_uitest.cc? http://codereview.chromium.org/10544104/diff/6002/ppapi/tests/test_graphics_3d.h File ppapi/tests/test_graphics_3d.h (right): http://codereview.chromium.org/10544104/diff/6002/ppapi/tests/test_graphics_3d.h#newcode33 ppapi/tests/test_graphics_3d.h:33: std::string TestPixelPPAPI(pp::Graphics3D* ...
8 years, 6 months ago (2012-06-13 22:59:31 UTC) #2
nfullagar
On 2012/06/13 22:59:31, viettrungluu wrote: > Should these tests be run from ppapi_uitest.cc? Yes, they ...
8 years, 6 months ago (2012-06-13 23:29:43 UTC) #3
viettrungluu
lgtm
8 years, 6 months ago (2012-06-14 18:24:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/10544104/6003
8 years, 6 months ago (2012-06-14 19:51:01 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-14 22:37:07 UTC) #6
Change committed as 142250

Powered by Google App Engine
This is Rietveld 408576698