Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3010)

Unified Diff: chrome/browser/process_singleton_win.cc

Issue 10542151: Move the window destruction and registration out of cleanup and into BrowserProcessImpl::EndSession… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/process_singleton.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/process_singleton_win.cc
===================================================================
--- chrome/browser/process_singleton_win.cc (revision 141718)
+++ chrome/browser/process_singleton_win.cc (working copy)
@@ -200,6 +200,8 @@
ProcessSingleton::~ProcessSingleton() {
Cleanup();
Jói 2012/06/15 10:04:57 nit: since Cleanup() is a no-op now, you could rem
+ // Make sure we unregister the window class during normal shutdown as well.
+ UnregisterWindowClass();
}
ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcess() {
@@ -302,12 +304,11 @@
}
void ProcessSingleton::Cleanup() {
+}
+
+void ProcessSingleton::UnregisterWindowClass() {
// Window classes registered by DLLs are not cleaned up automatically on
// process exit, so we must unregister at the earliest chance possible.
- // During the fast shutdown sequence, ProcessSingleton::Cleanup() is
- // called if our process was the first to start. Therefore we try cleaning
- // up here, and again in the destructor if needed to catch as many cases
- // as possible.
if (window_) {
::DestroyWindow(window_);
::UnregisterClass(chrome::kMessageWindowClass,
« no previous file with comments | « chrome/browser/process_singleton.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698