Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2770)

Unified Diff: chrome/browser/process_singleton.h

Issue 10542151: Move the window destruction and registration out of cleanup and into BrowserProcessImpl::EndSession… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/process_singleton.h
===================================================================
--- chrome/browser/process_singleton.h (revision 141718)
+++ chrome/browser/process_singleton.h (working copy)
@@ -109,7 +109,7 @@
bool FoundOtherProcessWindow() const {
return (NULL != remote_window_);
}
-#endif // defined(OS_WIN)
+#endif // defined(OS_WIN) && !defined(USE_AURA)
// Sets ourself up as the singleton instance. Returns true on success. If
// false is returned, we are not the singleton instance and the caller must
@@ -121,6 +121,13 @@
// Clear any lock state during shutdown.
void Cleanup();
+#if defined(OS_WIN)
+ // We need to unregister the window as late as possible so that we can detect
+ // another instance of chrome running. Otherwise we may end up writing out
+ // data while a new chrome is starting up.
+ void UnregisterWindowClass();
+#endif // defined(OS_WIN)
+
// Blocks the dispatch of CopyData messages. foreground_window refers
// to the window that should be set to the foreground if a CopyData message
// is received while the ProcessSingleton is locked.

Powered by Google App Engine
This is Rietveld 408576698