Use original WebKit IDL database for dart:html generation.

Use original WebKit IDL database for dart:html generation.

This will allow us to use the same database to generate both frog and native implementations.

R=antonm@google.com,sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=8458

[Anton Muhin, 2012-06-07 11:43:46]

lgtm

https://chromiumcodereview.appspot.com/10542036/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10542036/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:391: def ParametersInterfaceDeclaration(self,
rename_type=None):
why not rename_type=lambda x: x?

https://chromiumcodereview.appspot.com/10542036/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemfrog.py (right):

https://chromiumcodereview.appspot.com/10542036/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemfrog.py:165: def _ShouldNarrowToImplementationType(self,
type_name):
maybe pass a renamer here instead of doing if and rename?

https://chromiumcodereview.appspot.com/10542036/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10542036/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:613: if (parent.type.id in names_to_match or
up to you, but I find it somewhat hard to read, what about

if parent.type.id in names_to_match: return True
if not self._database.HasInterface(parent.type.id): continue
if self._HasAncestor(self._data....)

plus I believed we either already have or was dreaming of generic traversal of
inheritance chain, I'd suggest something like

def AllParents(interface, database):
  for parent in interface.parents:
    yield parent
    if not database.HasInterface(parent.type.id): continue
    for child in Parents(database.GetInterface(parent.type.id)):
      yield child

Now you can have a very nice _HasAncestor:

def _HasAncestor(self, interface, names_to_match):
  return any(parent.type.id in names_to_match for parent in
AllParents(interface, self._database)

https://chromiumcodereview.appspot.com/10542036/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:624: if (interface.id.startswith("HTML") and
nit: single quote strings, please

[podivilov, 2012-06-08 18:03:25]

Thanks!

http://codereview.chromium.org/10542036/diff/1/lib/dom/scripts/generator.py
File lib/dom/scripts/generator.py (right):

http://codereview.chromium.org/10542036/diff/1/lib/dom/scripts/generator.py#n...
lib/dom/scripts/generator.py:391: def ParametersInterfaceDeclaration(self,
rename_type=None):
On 2012/06/07 11:43:47, antonmuhin wrote:
> why not rename_type=lambda x: x?

Done.

http://codereview.chromium.org/10542036/diff/1/lib/dom/scripts/systemfrog.py
File lib/dom/scripts/systemfrog.py (right):

http://codereview.chromium.org/10542036/diff/1/lib/dom/scripts/systemfrog.py#...
lib/dom/scripts/systemfrog.py:165: def _ShouldNarrowToImplementationType(self,
type_name):
On 2012/06/07 11:43:47, antonmuhin wrote:
> maybe pass a renamer here instead of doing if and rename?

It might be a good idea, but there too many call sites that need renaming.

http://codereview.chromium.org/10542036/diff/1/lib/dom/scripts/systemhtml.py
File lib/dom/scripts/systemhtml.py (right):

http://codereview.chromium.org/10542036/diff/1/lib/dom/scripts/systemhtml.py#...
lib/dom/scripts/systemhtml.py:613: if (parent.type.id in names_to_match or
On 2012/06/07 11:43:47, antonmuhin wrote:
> up to you, but I find it somewhat hard to read, what about
> 
> if parent.type.id in names_to_match: return True
> if not self._database.HasInterface(parent.type.id): continue
> if self._HasAncestor(self._data....)
> 
> plus I believed we either already have or was dreaming of generic traversal of
> inheritance chain, I'd suggest something like
> 
> def AllParents(interface, database):
>   for parent in interface.parents:
>     yield parent
>     if not database.HasInterface(parent.type.id): continue
>     for child in Parents(database.GetInterface(parent.type.id)):
>       yield child
> 
> Now you can have a very nice _HasAncestor:
> 
> def _HasAncestor(self, interface, names_to_match):
>   return any(parent.type.id in names_to_match for parent in
> AllParents(interface, self._database)

Done.

http://codereview.chromium.org/10542036/diff/1/lib/dom/scripts/systemhtml.py#...
lib/dom/scripts/systemhtml.py:624: if (interface.id.startswith("HTML") and
On 2012/06/07 11:43:47, antonmuhin wrote:
> nit: single quote strings, please

Done.