Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10542010: TabContentsWrapper -> TabContents, part 2. (Closed)

Created:
8 years, 6 months ago by Avi (use Gerrit)
Modified:
8 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, dyu1, dhollowa+watch_chromium.org, ajwong+watch_chromium.org, kkania, robertshield, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org, Ilya Sherman
Visibility:
Public.

Description

TabContentsWrapper -> TabContents, part 2. BUG=131026 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140754

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase, rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -161 lines) Patch
M chrome/browser/autofill/autofill_external_delegate_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/autofill/autofill_manager_unittest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/autofill/autofill_metrics_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/download/download_request_limiter_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac_unittest.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/favicon_util.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/favicon_util.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper_unittest.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc View 10 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/find_bar/find_backend_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper_delegate.h View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 3 chunks +25 lines, -13 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_iterator.h View 4 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_iterator.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
A chrome/browser/ui/tab_contents/test_tab_contents.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/ui/tab_contents/test_tab_contents.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_unittest.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/web_applications/web_app_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Avi (use Gerrit)
8 years, 6 months ago (2012-06-05 23:11:27 UTC) #1
jam
lgtm http://codereview.chromium.org/10542010/diff/1/chrome/browser/ui/tab_contents/tab_contents.h File chrome/browser/ui/tab_contents/tab_contents.h (right): http://codereview.chromium.org/10542010/diff/1/chrome/browser/ui/tab_contents/tab_contents.h#newcode116 chrome/browser/ui/tab_contents/tab_contents.h:116: static const TabContents* GetOwningContentsForWebContents( nit: GetOwningTabContentsForWebContents?
8 years, 6 months ago (2012-06-05 23:55:42 UTC) #2
Avi (use Gerrit)
8 years, 6 months ago (2012-06-06 14:13:55 UTC) #3 
https://chromiumcodereview.appspot.com/10542010/diff/1/chrome/browser/ui/tab_...
File chrome/browser/ui/tab_contents/tab_contents.h (right):

https://chromiumcodereview.appspot.com/10542010/diff/1/chrome/browser/ui/tab_...
chrome/browser/ui/tab_contents/tab_contents.h:116: static const TabContents*
GetOwningContentsForWebContents(
On 2012/06/05 23:55:42, John Abd-El-Malek wrote:
> nit: GetOwningTabContentsForWebContents?

Yeah, once you get past twenty characters, I guess it's pointless to try to save
space.

Powered by Google App Engine
This is Rietveld 408576698