Notify CloseFile from Pepper to FileSystem.

webkit/plugins/ppapi/ppb_file_io_impl.cc

Index: webkit/plugins/ppapi/ppb_file_io_impl.cc
diff --git a/webkit/plugins/ppapi/ppb_file_io_impl.cc b/webkit/plugins/ppapi/ppb_file_io_impl.cc
index d1022709bbf48801b1fad183f63527e9f8349f14..94c4b7bc6357c97d86df20c9ae01592507969d1b 100644
--- a/webkit/plugins/ppapi/ppb_file_io_impl.cc
+++ b/webkit/plugins/ppapi/ppb_file_io_impl.cc
@@ -210,9 +210,13 @@ int32_t PPB_FileIO_Impl::FlushValidated(
 void PPB_FileIO_Impl::Close() {
   PluginDelegate* plugin_delegate = GetPluginDelegate();
   if (file_ != base::kInvalidPlatformFileValue && plugin_delegate) {
+    base::FileUtilProxy::StatusCallback callback;
+    if (!file_system_url_.is_empty()) {

[zel, 2012/06/26 01:42:18]

file_system_url_ is going to be set only for local (temp/permanent) file
systems. - see OpenValidated() above

[kinaba, 2012/06/26 04:19:22]

Fmm, is it?
I thought the code pass (not HasValidFileSystem() and proceed to AsyncOpenFile)
is only for files given as a single isolated file (like the ones from file
chooser dialog). If the file is opened via normal Pepper API pp::FileSystem and
pp::FileRef, I thought it should come with a valid file system.
Could you send me your test NaCl plugin? I'd like to test on it.

[kinuko, 2012/06/26 11:13:36]

EXTERNAL file could be created without file system instance, but the code looks
it's also possible to open an EXTERNAL filesystem and open a file in the
filesystem, in that case we have file_system_url_ set in the file's FileIO.
(I haven't tested the code path by myself so I'm not 100% sure though)

[zel, 2012/06/26 23:51:57]

Yeah, that seems correct. NaCl has two inconsistent paths for dealing with
external files. The one that works with file picker won't really work for this
notification.

[kinaba, 2012/06/27 03:47:42]

And I believe it is meant for read-only file open that doesn't require the
open/close notification.

+      callback = plugin_delegate->GetCloseFileSystemURLCallback(
+          file_system_url_);
+    }
     base::FileUtilProxy::Close(
-        plugin_delegate->GetFileThreadMessageLoopProxy(), file_,
-        base::FileUtilProxy::StatusCallback());
+        plugin_delegate->GetFileThreadMessageLoopProxy(), file_, callback);
     file_ = base::kInvalidPlatformFileValue;
     quota_file_io_.reset();
   }