Notify CloseFile from Pepper to FileSystem.

webkit/plugins/ppapi/ppb_file_io_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppb_file_io_impl.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/file_util.h"
 #include "base/file_util_proxy.h"
@@ skipping 192 matching lines @@
                      weak_factory_.GetWeakPtr())))
     return PP_ERROR_FAILED;
 
   RegisterCallback(OPERATION_EXCLUSIVE, callback, NULL, NULL);
   return PP_OK_COMPLETIONPENDING;
 }
 
 void PPB_FileIO_Impl::Close() {
   PluginDelegate* plugin_delegate = GetPluginDelegate();
   if (file_ != base::kInvalidPlatformFileValue && plugin_delegate) {
+    base::FileUtilProxy::StatusCallback callback;
+    if (!file_system_url_.is_empty()) {

[zel, 2012/06/26 01:42:18]

file_system_url_ is going to be set only for local (temp/permanent) file
systems. - see OpenValidated() above

[kinaba, 2012/06/26 04:19:22]

Fmm, is it?
I thought the code pass (not HasValidFileSystem() and proceed to AsyncOpenFile)
is only for files given as a single isolated file (like the ones from file
chooser dialog). If the file is opened via normal Pepper API pp::FileSystem and
pp::FileRef, I thought it should come with a valid file system.
Could you send me your test NaCl plugin? I'd like to test on it.

[kinuko, 2012/06/26 11:13:36]

EXTERNAL file could be created without file system instance, but the code looks
it's also possible to open an EXTERNAL filesystem and open a file in the
filesystem, in that case we have file_system_url_ set in the file's FileIO.
(I haven't tested the code path by myself so I'm not 100% sure though)

[zel, 2012/06/26 23:51:57]

Yeah, that seems correct. NaCl has two inconsistent paths for dealing with
external files. The one that works with file picker won't really work for this
notification.

[kinaba, 2012/06/27 03:47:42]

And I believe it is meant for read-only file open that doesn't require the
open/close notification.

+      callback = plugin_delegate->GetCloseFileSystemURLCallback(
+          file_system_url_);
+    }
     base::FileUtilProxy::Close(
-        plugin_delegate->GetFileThreadMessageLoopProxy(), file_,
-        base::FileUtilProxy::StatusCallback());
+        plugin_delegate->GetFileThreadMessageLoopProxy(), file_, callback);
     file_ = base::kInvalidPlatformFileValue;
     quota_file_io_.reset();
   }
 }
 
 int32_t PPB_FileIO_Impl::GetOSFileDescriptor() {
 #if defined(OS_POSIX)
   return file_;
 #elif defined(OS_WIN)
   return reinterpret_cast<uintptr_t>(file_);
@@ skipping 113 matching lines @@
   if (error_code != base::PLATFORM_FILE_OK) {
     RunAndRemoveFirstPendingCallback(
         ::ppapi::PlatformFileErrorToPepperError(error_code));
   } else {
     RunAndRemoveFirstPendingCallback(bytes_written);
   }
 }
 
 }  // namespace ppapi
 }  // namespace webkit