Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 10541095: Disallow underscores in named formal parameters. (Closed)

Created:
8 years, 6 months ago by zundel
Modified:
8 years, 6 months ago
Reviewers:
gbracha, scheglov, gram
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Disallow underscores in named formal parameters. See issue http://code.google.com/p/dart/issues/detail?id=2493 Committed: https://code.google.com/p/dart/source/detail?r=8631

Patch Set 1 : # #

Patch Set 2 : # #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -15 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java View 2 chunks +10 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 2 chunks +10 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java View 1 1 chunk +28 lines, -0 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/parameter_initializer6_negative_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M tests/language/parameter_initializer_test.dart View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
zundel
Submitting unit tests and core library changes under a different patch: http://codereview.chromium.org/10545114/
8 years, 6 months ago (2012-06-11 15:53:30 UTC) #1
gram
lgtm I'm not familiar with the compiler source although the changes there looked reasonable to ...
8 years, 6 months ago (2012-06-11 15:58:07 UTC) #2
zundel
Committed the library changes separately in r8536. This patch is blocked on addressing a few ...
8 years, 6 months ago (2012-06-12 12:01:47 UTC) #3
zundel
@Gilad, could you review the _test.dart files? Thanks
8 years, 6 months ago (2012-06-12 13:26:27 UTC) #4
gbracha
On 2012/06/12 13:26:27, zundel wrote: > @Gilad, could you review the _test.dart files? Thanks lgtm
8 years, 6 months ago (2012-06-12 14:14:43 UTC) #5
scheglov
8 years, 6 months ago (2012-06-13 21:01:23 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698