Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java

Issue 10541095: Disallow underscores in named formal parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: # Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java b/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
index d5651fba1d82536eaed3ece65c28d678efe0f3a7..3aec6960b4d90413162688a9ea06c07f7e9dda0e 100644
--- a/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
+++ b/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
@@ -1264,4 +1264,32 @@ public class ResolverTest extends ResolverTestCase {
"}"),
errEx(ResolverErrorCode.CANNOT_RESOLVE_METHOD, 5, 5, 7));
}
+
+ public void testUndercoreInNamedParameterMethodDefinition() {
+ resolveAndTest(Joiner.on("\n").join(
+ "class Object {}",
+ "method([_foo]) {}",
+ "class Foo {",
+ " var _bar;",
+ " Foo([this._bar]){}",
+ " method([_foo]){}",
+ "}"),
+ errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 2, 9, 4),
+ errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 5, 8, 9),
+ errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 6, 11, 4));
+ }
+
+ public void testUndercoreInNamedParameterFunctionDefinition() {
+ resolveAndTest(Joiner.on("\n").join(
+ "class Object {}",
+ "var f = func([_foo]) {};"),
+ errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 2, 15, 4));
+ }
+
+ public void testUndercoreInNamedParameterFunctionAlias() {
+ resolveAndTest(Joiner.on("\n").join(
+ "class Object {}",
+ "typedef Object func([_foo]);"),
+ errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 2, 22, 4));
+ }
}
« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java ('k') | tests/co19/co19-compiler.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698