Refactor detection of account creation forms and fix two minor issues.

chrome/renderer/autofill/password_generation_manager.h

Index: chrome/renderer/autofill/password_generation_manager.h
diff --git a/chrome/renderer/autofill/password_generation_manager.h b/chrome/renderer/autofill/password_generation_manager.h
index e22531ead8a75269036363c34e9b4a9629e2d2a6..72c236cdf0959e0e5f9e2f8cd506dc53195e5a3c 100644
--- a/chrome/renderer/autofill/password_generation_manager.h
+++ b/chrome/renderer/autofill/password_generation_manager.h
@@ -40,7 +40,7 @@ class PasswordGenerationManager : public content::RenderViewObserver,
 
  private:
   // RenderViewObserver:
-  virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame) OVERRIDE;
+  virtual void DidFinishLoad(WebKit::WebFrame* frame) OVERRIDE;

[zysxqn, 2012/06/08 17:10:39]

is it because only until then will we know whether the password field is visible
or not?

[Garrett Casto, 2012/06/08 20:15:09]

Yeah, layout hasn't happened by DidFinishDocumentLoad time.

 
   // WebTextFieldDecoratorClient:
   virtual bool shouldAddDecorationTo(
@@ -50,7 +50,10 @@ class PasswordGenerationManager : public content::RenderViewObserver,
   virtual WebKit::WebCString imageNameForDisabledState() OVERRIDE;
   virtual WebKit::WebCString imageNameForReadOnlyState() OVERRIDE;
   virtual void handleClick(WebKit::WebInputElement& element) OVERRIDE;
-  virtual void willDetach(const WebKit::WebInputElement&) OVERRIDE;
+  virtual void willDetach(const WebKit::WebInputElement& element) OVERRIDE;
+
+  bool IsAccountCreationForm(const WebKit::WebFormElement& form,
+                             std::vector<WebKit::WebInputElement>* passwords);

[Ilya Sherman, 2012/06/08 05:22:18]

nit: The method name does not give any indication that the |passwords| vector
will be modified by this method.  Perhaps "GetAccountCreationPasswordFields"?

[Ilya Sherman, 2012/06/08 05:22:18]

nit: Can this be tucked into an anonymous namespace in the implementation file?

[Garrett Casto, 2012/06/08 20:15:09]

Done.

[Garrett Casto, 2012/06/08 20:15:09]

Done.

 
   // Message handlers.
   void OnPasswordAccepted(const string16& password);