Refactor detection of account creation forms and fix two minor issues.

chrome/renderer/autofill/password_generation_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_AUTOFILL_PASSWORD_GENERATION_MANAGER_H_
 #define CHROME_RENDERER_AUTOFILL_PASSWORD_GENERATION_MANAGER_H_
 #pragma once
 
 #include <map>
 #include <utility>
@@ skipping 22 matching lines @@
  protected:
   // Returns true if this document is one that we should consider analyzing.
   // Virtual so that it can be overriden during testing.
   virtual bool ShouldAnalyzeDocument(const WebKit::WebDocument& document) const;
 
   // RenderViewObserver:
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
  private:
   // RenderViewObserver:
-  virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame) OVERRIDE;
+  virtual void DidFinishLoad(WebKit::WebFrame* frame) OVERRIDE;

[zysxqn, 2012/06/08 17:10:39]

is it because only until then will we know whether the password field is visible
or not?

[Garrett Casto, 2012/06/08 20:15:09]

Yeah, layout hasn't happened by DidFinishDocumentLoad time.

 
   // WebTextFieldDecoratorClient:
   virtual bool shouldAddDecorationTo(
       const WebKit::WebInputElement& element) OVERRIDE;
   virtual bool visibleByDefault() OVERRIDE;
   virtual WebKit::WebCString imageNameForNormalState() OVERRIDE;
   virtual WebKit::WebCString imageNameForDisabledState() OVERRIDE;
   virtual WebKit::WebCString imageNameForReadOnlyState() OVERRIDE;
   virtual void handleClick(WebKit::WebInputElement& element) OVERRIDE;
-  virtual void willDetach(const WebKit::WebInputElement&) OVERRIDE;
+  virtual void willDetach(const WebKit::WebInputElement& element) OVERRIDE;
+
+  bool IsAccountCreationForm(const WebKit::WebFormElement& form,
+                             std::vector<WebKit::WebInputElement>* passwords);

[Ilya Sherman, 2012/06/08 05:22:18]

nit: The method name does not give any indication that the |passwords| vector
will be modified by this method.  Perhaps "GetAccountCreationPasswordFields"?

[Ilya Sherman, 2012/06/08 05:22:18]

nit: Can this be tucked into an anonymous namespace in the implementation file?

[Garrett Casto, 2012/06/08 20:15:09]

Done.

[Garrett Casto, 2012/06/08 20:15:09]

Done.

 
   // Message handlers.
   void OnPasswordAccepted(const string16& password);
   void OnPasswordGenerationEnabled(bool enabled);
 
   // True if password generation is enabled for the profile associated
   // with this renderer.
   bool enabled_;
 
   std::vector<WebKit::WebInputElement> passwords_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordGenerationManager);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_RENDERER_AUTOFILL_PASSWORD_GENERATION_MANAGER_H_