Simplify generated code for trivial bailout methods.

Simplify generated code for trivial bailout methods.
Committed: https://code.google.com/p/dart/source/detail?r=8592

[kasperl, 2012-06-12 12:18:40]

LGTM.

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/ssa/bailout.dart (right):

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/bailout.dart:29: // We don't need to an code
motion invariant instructions in the
need to an code?

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/bailout.dart:30: // live set except for
parameters that are not 'this' ('this' is
('this' is -> , which is

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/bailout.dart:219: int state;
I would move 'int state' down below the comment.

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/bailout.dart:389: 
Remove one newline here.

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/bailout.dart:523: // Sort the names of all type
guards, to be able to merge
to be able to -> so we can

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:2593: labels = <String>[] {
Keep ;

[ngeoffray, 2012-06-12 12:28:18]

Thanks Kasper

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/ssa/bailout.dart (right):

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/bailout.dart:29: // We don't need to an code
motion invariant instructions in the
On 2012/06/12 12:18:40, kasperl wrote:
> need to an code?

Done.

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/bailout.dart:30: // live set except for
parameters that are not 'this' ('this' is
On 2012/06/12 12:18:40, kasperl wrote:
> ('this' is -> , which is 

Done.

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/bailout.dart:219: int state;
On 2012/06/12 12:18:40, kasperl wrote:
> I would move 'int state' down below the comment.

Done.

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/bailout.dart:389: 
On 2012/06/12 12:18:40, kasperl wrote:
> Remove one newline here.

Done.

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/bailout.dart:523: // Sort the names of all type
guards, to be able to merge
On 2012/06/12 12:18:40, kasperl wrote:
> to be able to -> so we can

Done.

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:2593: labels = <String>[] {
On 2012/06/12 12:18:40, kasperl wrote:
> Keep ;

Done.

[floitsch, 2012-06-12 15:01:17]

LGTM.

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/ssa/bailout.dart (right):

https://chromiumcodereview.appspot.com/10539106/diff/4001/lib/compiler/implem...
lib/compiler/implementation/ssa/bailout.dart:32: if
(!instruction.isCodeMotionInvariant()
Explain that this is, because we generate these at use-site.
Any possibility to ensure this (like asserts)?

[ngeoffray, 2012-06-12 16:08:40]

PTAL. I had to fix a couple of problems after Mads' change where we start
generating a lot of bailout methods.

[kasperl, 2012-06-13 07:37:05]

LGTM.

http://codereview.chromium.org/10539106/diff/2005/lib/compiler/implementation...
File lib/compiler/implementation/ssa/bailout.dart (right):

http://codereview.chromium.org/10539106/diff/2005/lib/compiler/implementation...
lib/compiler/implementation/ssa/bailout.dart:393:
SsaBailoutPropagator(this.compiler,
Arguments fit on one line.

[ngeoffray, 2012-06-13 07:41:38]

Thanks Kasper

http://codereview.chromium.org/10539106/diff/2005/lib/compiler/implementation...
File lib/compiler/implementation/ssa/bailout.dart (right):

http://codereview.chromium.org/10539106/diff/2005/lib/compiler/implementation...
lib/compiler/implementation/ssa/bailout.dart:393:
SsaBailoutPropagator(this.compiler,
On 2012/06/13 07:37:05, kasperl wrote:
> Arguments fit on one line.

Done.