NetLogEventParameter to Callback refactoring 1,

net/base/net_log.h

Index: net/base/net_log.h
===================================================================
--- net/base/net_log.h	(revision 141407)
+++ net/base/net_log.h	(working copy)
@@ -296,6 +296,13 @@
   // Warning: |name| must remain valid for the life of the callback.
   static ParametersCallback IntegerCallback(const char* name, int value);
 
+  // Creates a ParametersCallback that encapsulates a single integer.  Takes

[eroman, 2012/06/11 23:42:25]

Update comment: "single integer" --> string

[mmenke, 2012/06/12 00:42:19]

Done.

+  // |value| as a pointer to avoid copying, and emphasize it must be valid for

[eroman, 2012/06/11 23:42:25]

Should we describe anything about the encoding of |value|?

[mmenke, 2012/06/12 00:42:19]

Done, though we actually violate it at times (Since we just stick in some header
lines that may not actually be in UTF 8).

+  // the life of the callback.
+  // Warning: |name| and |value| must remain valid for the life of the callback.
+  static ParametersCallback StringCallback(const char* name,
+                                           const std::string* value);
+
  protected:
   // Child classes should respond to the new entry here.  This includes
   // creating the Entry object and alerting their observers.