NetLogEventParameter to Callback refactoring 1,

net/base/net_log.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NET_LOG_H_
 #define NET_BASE_NET_LOG_H_
 #pragma once
 
 #include <string>
 
@@ skipping 278 matching lines @@
 
   // Returns true if |log_level| indicates that all events should be logged,
   // including frequently occuring ones that may impact performances.
   // This is the case when |log_level| is LOG_ALL or LOG_ALL_BUT_BYTES.
   static bool IsLoggingAllEvents(LogLevel log_level);
 
   // Creates a ParametersCallback that encapsulates a single integer.
   // Warning: |name| must remain valid for the life of the callback.
   static ParametersCallback IntegerCallback(const char* name, int value);
 
+  // Creates a ParametersCallback that encapsulates a single integer.  Takes

[eroman, 2012/06/11 23:42:25]

Update comment: "single integer" --> string

[mmenke, 2012/06/12 00:42:19]

Done.

+  // |value| as a pointer to avoid copying, and emphasize it must be valid for

[eroman, 2012/06/11 23:42:25]

Should we describe anything about the encoding of |value|?

[mmenke, 2012/06/12 00:42:19]

Done, though we actually violate it at times (Since we just stick in some header
lines that may not actually be in UTF 8).

+  // the life of the callback.
+  // Warning: |name| and |value| must remain valid for the life of the callback.
+  static ParametersCallback StringCallback(const char* name,
+                                           const std::string* value);
+
  protected:
   // Child classes should respond to the new entry here.  This includes
   // creating the Entry object and alerting their observers.
   virtual void OnAddEntry(const Entry& entry) = 0;
 
   // Subclasses must call these in the corresponding functions to set an
   // observer's |net_log_| and |log_level_| values.
   void OnAddObserver(ThreadSafeObserver* observer, LogLevel log_level);
   void OnSetObserverLogLevel(ThreadSafeObserver* observer,
                              LogLevel log_level);
@@ skipping 156 matching lines @@
   virtual ~NetLogSourceParameter() {}
 
  private:
   const char* name_;
   const NetLog::Source value_;
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_NET_LOG_H_