net/socket/tcp_client_socket_win.cc - Issue 10539094: NetLogEventParameter to Callback refactoring 1, - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1536)

My Issues | Starred Open | Closed | All

Unified Diff: net/socket/tcp_client_socket_win.cc

Issue 10539094: NetLogEventParameter to Callback refactoring 1, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Add comment Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« net/base/x509_certificate_net_log_param.h ('K') | « net/socket/tcp_client_socket_libevent.cc ('k') | net/udp/udp_data_transfer_param.h » ('j') | net/udp/udp_data_transfer_param.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/socket/tcp_client_socket_win.cc

===================================================================

--- net/socket/tcp_client_socket_win.cc (revision 141407)

+++ net/socket/tcp_client_socket_win.cc (working copy)

@@ -7,12 +7,12 @@

#include <mstcpip.h>

#include "base/basictypes.h"

+#include "base/bind.h"

eroman 2012/06/12 05:17:26 nit: is this still used?

mmenke 2012/06/12 14:52:36 Nope. Removed.

#include "base/compiler_specific.h"

#include "base/metrics/stats_counters.h"

#include "base/string_util.h"

#include "base/win/object_watcher.h"

#include "base/win/windows_version.h"

-#include "net/base/address_list_net_log_param.h"

#include "net/base/connection_type_histograms.h"

#include "net/base/io_buffer.h"

#include "net/base/ip_endpoint.h"

@@ -406,7 +406,7 @@

connects.Increment();

net_log_.BeginEvent(NetLog::TYPE_TCP_CONNECT,

- new AddressListNetLogParam(addresses_));

+ addresses_.CreateNetLogCallback());

// We will try to connect to each address in addresses_. Start with the

// first one in the list.

« net/base/x509_certificate_net_log_param.h ('K') | « net/socket/tcp_client_socket_libevent.cc ('k') | net/udp/udp_data_transfer_param.h » ('j') | net/udp/udp_data_transfer_param.h » ('J')

Powered by Google App Engine

This is Rietveld 408576698