NetLogEventParameter to Callback refactoring 1,

net/base/x509_certificate_net_log_param.h

Index: net/base/x509_certificate_net_log_param.h
===================================================================
--- net/base/x509_certificate_net_log_param.h	(revision 141407)
+++ net/base/x509_certificate_net_log_param.h	(working copy)
@@ -6,32 +6,19 @@
 #define NET_BASE_X509_CERT_NET_LOG_PARAM_H_
 #pragma once
 
-#include <string>
-#include <vector>
-
-#include "base/compiler_specific.h"
+#include "base/memory/ref_counted.h"

[eroman, 2012/06/12 05:17:26]

nit: don't need this anymore

[mmenke, 2012/06/12 14:52:36]

Done.

 #include "net/base/net_log.h"
 
 namespace net {
 
 class X509Certificate;
 
-// NetLog parameter to describe an X509Certificate.
-// Note: These parameters are memory intensive, due to PEM-encoding each
-// certificate, thus should only be used when logging at NetLog::LOG_ALL.
-class X509CertificateNetLogParam : public NetLog::EventParameters {
- public:
-  explicit X509CertificateNetLogParam(X509Certificate* certificate);
+// Creates NetLog parameter to describe an X509Certificate.
+// These parameters are memory intensive, due to PEM-encoding each certificate.

[eroman, 2012/06/12 05:17:26]

nit: maybe just delete this comment alltogether (not sure it adds value anymore)

[mmenke, 2012/06/12 14:52:36]

Done.

+base::Value* NetLogX509CertificateCallback(
+    const X509Certificate* certificate,
+    NetLog::LogLevel log_level);
 
-  virtual base::Value* ToValue() const OVERRIDE;
-
- protected:
-  virtual ~X509CertificateNetLogParam();
-
- private:
-  std::vector<std::string> encoded_chain_;
-};
-
 }  // namespace net
 
 #endif  // NET_BASE_X509_CERT_NET_LOG_PARAM_H_