Issue 10539075: Fix for issue 1335

Issue 10539075: Fix for issue 1335 (Closed)

Created:
8 years, 6 months ago by Brian Wilkerson

Modified:
8 years, 6 months ago

Reviewers:
scheglov, zundel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for issue 1335 Committed: https://code.google.com/p/dart/source/detail?r=8490

Patch Set 3 : #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -25 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View		1 chunk	+8 lines, -5 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	1 2	4 chunks	+7 lines, -10 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Scope.java	View	1 2	5 chunks	+18 lines, -9 lines	2 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

zundel

http://codereview.chromium.org/10539075/diff/2001/compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java File compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java (right): http://codereview.chromium.org/10539075/diff/2001/compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java#newcode246 compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java:246: " a: b: foo();", In the Resolver, there is ...

8 years, 6 months ago (2012-06-08 21:29:05 UTC) #2

zundel

lgtm http://codereview.chromium.org/10539075/diff/6001/compiler/java/com/google/dart/compiler/resolver/Scope.java File compiler/java/com/google/dart/compiler/resolver/Scope.java (right): http://codereview.chromium.org/10539075/diff/6001/compiler/java/com/google/dart/compiler/resolver/Scope.java#newcode90 compiler/java/com/google/dart/compiler/resolver/Scope.java:90: // public Element getLabel() { remove me

8 years, 6 months ago (2012-06-08 23:13:07 UTC) #4

Brian Wilkerson

8 years, 6 months ago (2012-06-11 15:06:00 UTC) #6

http://codereview.chromium.org/10539075/diff/6001/compiler/java/com/google/da...
File compiler/java/com/google/dart/compiler/resolver/Scope.java (right):

http://codereview.chromium.org/10539075/diff/6001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/resolver/Scope.java:90: //  public
Element getLabel() {
Done

Expand Messages | Collapse Messages