[Chromoting] Make ChromotingHost's dependency on libjingle injected, instead of hard-coded.

remoting/host/jingle_session_manager_factory.h

Index: remoting/host/jingle_session_manager_factory.h
diff --git a/remoting/host/jingle_session_manager_factory.h b/remoting/host/jingle_session_manager_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..bf0e942dbde95712e12264545ef78e5c58dd999b
--- /dev/null
+++ b/remoting/host/jingle_session_manager_factory.h
@@ -0,0 +1,30 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_JINGLE_SESSION_MANAGER_FACTORY_H_
+#define REMOTING_HOST_JINGLE_SESSION_MANAGER_FACTORY_H_
+
+#include "base/memory/scoped_ptr.h"
+#include "net/url_request/url_request_context_getter.h"
+#include "remoting/protocol/session_manager.h"
+
+namespace remoting {
+
+struct NetworkSettings;
+
+// A factory for Jingle-protocol session managers.
+class JingleSessionManagerFactory {

[Wez, 2012/06/12 21:20:10]

There's really no need for this class now that the Create method is static.

[simonmorris, 2012/06/13 16:26:33]

Done.

+ public:
+  static scoped_ptr<protocol::SessionManager> CreateSessionManager(

[Wez, 2012/06/12 21:20:10]

This factory function creates a SessionManager based on a host-specific
PortAllocator, and has an interface that accepts host-specific NetworkSettings,
so it's not a general Jingle-based SessionManager factory as such; it should
probably be CreateHostSessionManager to match HostPortAllocator.

It might also make calling code sites easier to read if this were implemented as
a HostSessionManager class, inheriting from JingleSessionManager and doing the
necessary initialization in the ctor.

[Sergey Ulanov, 2012/06/13 01:57:19]

I think it might be better to move it to JinlgeSessionManager class and call it
CreateForHost() or something line that.

[simonmorris, 2012/06/13 16:26:33]

Done.
A separate class, that inherits implementation, is too heavyweight if the only
benefit is replacing a Create* function with a constructor.

[simonmorris, 2012/06/13 16:26:33]

JingleSessionManager is in remoting/protocol, so shouldn't depend on
remoting/host.

+      const NetworkSettings& network_settings,
+      const scoped_refptr<net::URLRequestContextGetter>&
+          url_request_context_getter) OVERRIDE;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(JingleSessionManagerFactory);
+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_HOST_JINGLE_SESSION_MANAGER_FACTORY_H_