remoting/host/jingle_session_manager_factory.h - Issue 10538091: [Chromoting] Make ChromotingHost's dependency on libjingle injected, instead of hard-coded.

Side by Side Diff: remoting/host/jingle_session_manager_factory.h

Issue 10538091: [Chromoting] Make ChromotingHost's dependency on libjingle injected, instead of hard-coded. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix remoting.gyp. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef REMOTING_HOST_JINGLE_SESSION_MANAGER_FACTORY_H_

	6 #define REMOTING_HOST_JINGLE_SESSION_MANAGER_FACTORY_H_

	7

	8 #include "base/memory/scoped_ptr.h"

	9 #include "net/url_request/url_request_context_getter.h"

	10 #include "remoting/protocol/session_manager.h"

	11

	12 namespace remoting {

	13

	14 struct NetworkSettings;

	15

	16 // A factory for Jingle-protocol session managers.

	17 class JingleSessionManagerFactory {
	Wez 2012/06/12 21:20:10 There's really no need for this class now that the There's really no need for this class now that the Create method is static. simonmorris 2012/06/13 16:26:33 Done. Show quoted text On 2012/06/12 21:20:10, Wez wrote: > There's really no need for this class now that the Create method is static. Done.
	18 public:

	19 static scoped_ptr<protocol::SessionManager> CreateSessionManager(
	Wez 2012/06/12 21:20:10 This factory function creates a SessionManager bas This factory function creates a SessionManager based on a host-specific PortAllocator, and has an interface that accepts host-specific NetworkSettings, so it's not a general Jingle-based SessionManager factory as such; it should probably be CreateHostSessionManager to match HostPortAllocator. It might also make calling code sites easier to read if this were implemented as a HostSessionManager class, inheriting from JingleSessionManager and doing the necessary initialization in the ctor. Sergey Ulanov 2012/06/13 01:57:19 I think it might be better to move it to JinlgeSes I think it might be better to move it to JinlgeSessionManager class and call it CreateForHost() or something line that. simonmorris 2012/06/13 16:26:33 Done. Show quoted text On 2012/06/12 21:20:10, Wez wrote: > This factory function creates a SessionManager based on a host-specific > PortAllocator, and has an interface that accepts host-specific NetworkSettings, > so it's not a general Jingle-based SessionManager factory as such; it should > probably be CreateHostSessionManager to match HostPortAllocator. > Done. Show quoted text > It might also make calling code sites easier to read if this were implemented as > a HostSessionManager class, inheriting from JingleSessionManager and doing the > necessary initialization in the ctor. A separate class, that inherits implementation, is too heavyweight if the only benefit is replacing a Create* function with a constructor. simonmorris 2012/06/13 16:26:33 JingleSessionManager is in remoting/protocol, so s Show quoted text On 2012/06/13 01:57:19, sergeyu wrote: > I think it might be better to move it to JinlgeSessionManager class and call it > CreateForHost() or something line that. JingleSessionManager is in remoting/protocol, so shouldn't depend on remoting/host.
	20 const NetworkSettings& network_settings,

	21 const scoped_refptr<net::URLRequestContextGetter>&

	22 url_request_context_getter) OVERRIDE;

	23

	24 private:

	25 DISALLOW_COPY_AND_ASSIGN(JingleSessionManagerFactory);

	26 };

	27

	28 } // namespace remoting

	29

	30 #endif // REMOTING_HOST_JINGLE_SESSION_MANAGER_FACTORY_H_

OLD	NEW