Issue 10538055: Fix make backend to correctly handle rules with output files of the same name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10538055: Fix make backend to correctly handle rules with output files of the same name (Closed)

Created:
8 years, 6 months ago by Steve Block

Modified:
8 years, 6 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Fix make backend to correctly handle rules with output files of the same name TEST=test/same-rule-output-file-name r1413

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -13 lines)			Patch
M	pylib/gyp/generator/make.py	View	1	4 chunks	+2 lines, -13 lines	0 comments	Download
A	test/same-rule-output-file-name/gyptest-all.py	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download
A	test/same-rule-output-file-name/src/subdir1/subdir1.gyp	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	test/same-rule-output-file-name/src/subdir2/subdir2.gyp	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	test/same-rule-output-file-name/src/subdirs.gyp	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
A	test/same-rule-output-file-name/src/touch.py	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Steve Block

Could you land, as I don't yet have my commit bit? > Please roll gyp ...

8 years, 6 months ago (2012-06-08 15:10:28 UTC) #3